Skip to content

Use PooledContextFactory #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Use PooledContextFactory #34

wants to merge 16 commits into from

Conversation

benaadams
Copy link
Contributor

Also needs aspnet/HttpAbstractions#501 to work

Took out SupportsSendFile as it doesn't exist anymore

/cc @DamianEdwards

@dnfclas
Copy link

dnfclas commented Dec 6, 2015

Hi @benaadams, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@benaadams benaadams mentioned this pull request Dec 6, 2015
Closed
@benaadams benaadams force-pushed the pooled-context-factory branch from 1b081b7 to 2068ce6 Compare December 7, 2015 00:25
@benaadams benaadams mentioned this pull request Dec 7, 2015
Closed
@benaadams benaadams force-pushed the pooled-context-factory branch from 2068ce6 to 8c7e97f Compare December 7, 2015 03:37
@benaadams
Copy link
Contributor Author

Usual stuff, 4k requests, 16 pipelined, using FF

Pre-allocations for DefaultContext 1.12MB

before-allocs

Post-allocations for DefaultContext 160KB

after-allocs

Almost all of which is logging scope

before-allocs

Not quite sure what's going on with ThreadStatic, but don't use it much - take the locks out and it goes a bit weird.

@benaadams benaadams force-pushed the pooled-context-factory branch from 8c7e97f to 9fceb96 Compare December 7, 2015 09:55
@benaadams benaadams mentioned this pull request Dec 7, 2015
Closed
@AspNetSmurfLab
Copy link
Contributor

Mixed results with this. For non-pipelined tests it seems to improve things, but for pipelined tests it makes this much worse (~10% drop in RPS).

@rynowak
Copy link
Member

rynowak commented Dec 9, 2015

Sounds like contention yo

@benaadams
Copy link
Contributor Author

Rookie mistake - didn't actually make the ThreadStatic static

@benaadams benaadams force-pushed the pooled-context-factory branch from d2235b9 to b9728d4 Compare December 10, 2015 18:54
Cesar Blum Silveira and others added 15 commits December 14, 2015 12:42
Add missing dependency to project.json.
1f74312
@davidfowl
Fixed the benchmarks
4acaef9 
- Use the new hosting API
- Found a CoreCLR bug with intercept = true on *nix
@benaadams
OrdinalIgnoreCase is unnecessary
12a2689 
https://www.techempower.com/benchmarks/#section=code&hw=peak&test=json
> General requirements
3. Specific characters and character case matter.
Typo in intro text
842276e
@pranavkm
Adding build.cmd
4e51e96
@JunTaoLuo
Reacting to hosting rename
56268af
Rename AspNet 5 file contents.
10a6c63 
See aspnet/Announcements#144 for more information.
Update ASP.NET 5 versions for ASP.NET Core.
1d8f07c 
See aspnet/Announcements#144 for more information.
@DamianEdwards
WIP
47c6d36
@DamianEdwards
Ability to enable specific scenarios:
fa502de 
- Updated for rename too
- Removed hosting.json
@DamianEdwards
Tweak default middleware message
e67daaa
@DamianEdwards
Switch to using net451 TFM instead of dnx451
0bf5694
@DamianEdwards
Merge pull request aspnet#43 from simonmurdock/dev
9c28d87 
Typo in intro text
@DamianEdwards
Merge pull request aspnet#42 from benaadams/patch-5
0ac3574 
OrdinalIgnoreCase is unnecessary
@DamianEdwards
Remove remaining OrdinalIgnoreCase path checks
a263612
@DamianEdwards
Copy link
Member

@benaadams would you mind rebasing this so we can re-measure pls?

@benaadams benaadams force-pushed the pooled-context-factory branch from b9728d4 to 82395c6 Compare January 27, 2016 00:27
@benaadams
Copy link
Contributor Author

O_o did I rebase on wrong thing?

@benaadams benaadams force-pushed the pooled-context-factory branch from 82395c6 to 648217f Compare January 27, 2016 00:32
@benaadams benaadams mentioned this pull request Jan 27, 2016
Closed
@benaadams
Copy link
Contributor Author

Submitted new PR #49

@benaadams benaadams closed this Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-measuring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@benaadams @dnfclas @AspNetSmurfLab @rynowak @DamianEdwards @davidfowl @pranavkm @JunTaoLuo