-
Notifications
You must be signed in to change notification settings - Fork 241
Use PooledContextFactory #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @benaadams, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
1b081b7 to
2068ce6
Compare
2068ce6 to
8c7e97f
Compare
8c7e97f to
9fceb96
Compare
|
Mixed results with this. For non-pipelined tests it seems to improve things, but for pipelined tests it makes this much worse (~10% drop in RPS). |
|
Sounds like contention yo |
|
Rookie mistake - didn't actually make the |
d2235b9 to
b9728d4
Compare
- Use the new hosting API - Found a CoreCLR bug with intercept = true on *nix
https://www.techempower.com/benchmarks/#section=code&hw=peak&test=json > General requirements 3. Specific characters and character case matter.
See aspnet/Announcements#144 for more information.
See aspnet/Announcements#144 for more information.
- Updated for rename too - Removed hosting.json
Typo in intro text
OrdinalIgnoreCase is unnecessary
|
@benaadams would you mind rebasing this so we can re-measure pls? |
b9728d4 to
82395c6
Compare
|
O_o did I rebase on wrong thing? |
82395c6 to
648217f
Compare
|
Submitted new PR #49 |



Also needs aspnet/HttpAbstractions#501 to work
Took out
SupportsSendFileas it doesn't exist anymore/cc @DamianEdwards