This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Move ConfigurationBinder to Configuration #205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
This was referenced May 20, 2015
|
In a mvc application startup what path should we specify on the ConfigurationBuilder? the above is the wwwroot path which seems wrong for config files? Leaving it empty currently also does not work for files in the same folder as project.json. Any suggestion? |
|
It's wrong for config files, you want |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @divega discussions with core configuration/options moving to BCL, the ConfigurationBinder was going to move to asp.net specific configuration. While only the DI specific options helpers will remain in Options repo, which will still depend on Configuration for the configure services sugar that uses the binder:
services.Configure<MyOptions>(config)The binder could live in ConfigurationModel.Abstractions if we were willing to make depend on reflection and add the error resources...
cc @victorhurdugaci I renamed TOptions => TModel since this is really a generic POCO binder anyways, there's nothing specific to options about the binder anyways...