This repository was archived by the owner on Nov 6, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 82
Un-nest private implentations of IFileInfo and IDirectoryContents #156
Comments
👍 We got some of the |
@mgrosperrin Feel free to submit a PR! Thanks |
For this change, would it make sense to move the non-primary API to a nested namespace?
This way we don't end up polluting the top level namespace when making the less common types public. |
Yeah, I think it makes sense. Of course it's hard to find good names for the namespace. |
I'll send a PR - we can discuss it as part of it. |
pranavkm
added a commit
that referenced
this issue
Dec 28, 2015
pranavkm
added a commit
that referenced
this issue
Dec 28, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As said in #142 (comment), the private implementations of
IFileInfo
andIDirectoryContents
should be un-nest and made public.I can submit a PR to do it.
The text was updated successfully, but these errors were encountered: