Skip to content
This repository was archived by the owner on Nov 6, 2018. It is now read-only.

Un-nest private implentations of IFileInfo and IDirectoryContents #156

Closed
mgrosperrin opened this issue Dec 14, 2015 · 5 comments
Closed

Comments

@mgrosperrin
Copy link
Contributor

As said in #142 (comment), the private implementations of IFileInfo and IDirectoryContents should be un-nest and made public.
I can submit a PR to do it.

@pranavkm
Copy link
Contributor

👍 We got some of the PhysicalFileProvider ones made public in a recent PR. Would be nice to make the remainder public too.

@muratg
Copy link

muratg commented Dec 28, 2015

@mgrosperrin Feel free to submit a PR! Thanks

@pranavkm
Copy link
Contributor

For this change, would it make sense to move the non-primary API to a nested namespace?
For instance:

  • Microsoft.AspNet.FileProviders.PhysicalFileProvider
  • Microsoft.AspNet.FileProviders.Physical.PhysicalDirectoryInfo (this would match the project name).

This way we don't end up polluting the top level namespace when making the less common types public.

@muratg
Copy link

muratg commented Dec 28, 2015

Yeah, I think it makes sense. Of course it's hard to find good names for the namespace.

@pranavkm
Copy link
Contributor

I'll send a PR - we can discuss it as part of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants