Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Register IApplicationDiscriminator service #1064

Merged
merged 1 commit into from
May 6, 2017
Merged

Register IApplicationDiscriminator service #1064

merged 1 commit into from
May 6, 2017

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented May 5, 2017

Moving this functionality from DataProtection so we can reverse the dependency.
aspnet/DataProtection#230
aspnet/Security#1201 (comment)

@Tratcher Tratcher added this to the 2.0.0-preview1 milestone May 5, 2017
@Tratcher Tratcher self-assigned this May 5, 2017
@Tratcher Tratcher requested review from davidfowl, Eilon and JunTaoLuo May 5, 2017 23:01
{
private readonly IHostingEnvironment _hostingEnvironment;

public ApplicationDiscriminator(IHostingEnvironment hostingEnv)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: hostingEnvironment

Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunTaoLuo JunTaoLuo merged commit 13ea876 into dev May 6, 2017
@JunTaoLuo JunTaoLuo deleted the tratcher/order branch May 6, 2017 00:12
natemcmaster pushed a commit that referenced this pull request Jun 1, 2017
Reverse changes made in #1064
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants