This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Cleanup for HttpAbstractions changes #409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TraceIdentifier is done at the last moment, or not at all * Request starting and finished messages are added * This pair provide many of the top-level values that you would have found in server log files.
|
Other changes required are in comments for #403 |
benaadams
force-pushed
the
cleanup-requestid
branch
from
8d224a2 to
9c79572
Compare
|
Fixed broken test found using aspnetvolatiledev Still issues with Coherence and HttpAbstractions; though not entirely sure what that means :) |
|
@benaadams :-) Our CI that verifies packages from aspnetvolatiledev and pushes them to aspnetcidev has been broken all day. |
benaadams
force-pushed
the
cleanup-requestid
branch
3 times, most recently
from
3ef9c32 to
e100c22
Compare
|
Working now 💃 |
benaadams
changed the title
benaadams
force-pushed
the
cleanup-requestid
branch
2 times, most recently
from
421eaed to
91436f2
Compare
benaadams
force-pushed
the
cleanup-requestid
branch
2 times, most recently
from
8c6360f to
2340941
Compare
benaadams
changed the title
benaadams
force-pushed
the
cleanup-requestid
branch
from
2340941 to
20b5df1
Compare
rynowak
force-pushed
the
lodejard/perf-logging
branch
2 times, most recently
from
3845e33 to
561b10b
Compare
|
Resolved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge RequestIdentifier cleanup from #394 from HttpAbstraction changes
As suggested by @Tratcher