This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Fixing deadlock hang in test when running in single threaded environment #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,7 +94,7 @@ public ClientHandler(PathString pathBase, IHttpApplication<Context> application) | |||
| } | |||
| }); | |||
|
|
|||
| return await state.ResponseTask; | |||
| return await state.ResponseTask.ConfigureAwait(false); | |||
There was a problem hiding this comment.
Though either the test change or the ConfigureAwait here will resolve the deadlock, it is suggested to do both here: http://blog.stephencleary.com/2012/07/dont-block-on-async-code.html
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the issue for #422. The test hangs because we are mixing async code in TestServer and blocking code in the test. This will cause a deadlock scenario but only when there is a single threaded scenario so it was undetected until now.