This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Renaming WebApplication* to WebHost* #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. As part of this change we should add 2 extension methods to clean up the Program.Main a bit more: public static IWebHostBuilder UseDefaultConfiguration(this IWebHostBuilder builder)
{
return builder.UseDefaultConfiguration(args: null);
}
public static IWebHostBuilder UseDefaultConfiguration(this IWebHostBuilder builder, string[] args)
{
return builder.UseConfiguration(WebHostConfiguration.GetDefault(args));
} |
|
|
||
| namespace Microsoft.AspNet.Hosting | ||
| { | ||
| public interface IWebHostBuilder |
There was a problem hiding this comment.
Add doc comments to the interface while you're at it?
|
Hosting.json -> WebHost.json wasn't a terrible suggestion. @davidfowl? |
Nah, I dont see a reason to change it. |
|
🆙📅 |
|
|
||
| namespace Microsoft.AspNet.Hosting | ||
| { | ||
| public static class WebHostBuilderExtensions |
There was a problem hiding this comment.
@davidfowl, @Tratcher also wanted to change this to something like WebHostBuilderBasicExtensions. I suggest *CoreExtensions if we really need to differentiate.
There was a problem hiding this comment.
Basic? Core? Why? This is the original library, everyone else can pick a worse name 😄
|
|
JunTaoLuo
force-pushed
the
johluo/webapp-rename
branch
from
da39401 to
aaf27a0
Compare
JunTaoLuo
force-pushed
the
johluo/webapp-rename
branch
from
aaf27a0 to
cad9ea1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#567 Did I missed anything? @Tratcher @davidfowl If not, I'll make all the updates to other repos tomorrow directly to their dev.