Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Review and update form parsing logic #119

Closed
Tratcher opened this issue Aug 26, 2014 · 7 comments
Closed

Review and update form parsing logic #119

Tratcher opened this issue Aug 26, 2014 · 7 comments
Labels

Comments

@Tratcher
Copy link
Member

src/Microsoft.AspNet.WebUtilities/ParsingHelpers.cs has at least one place where it calls char.IsWhiteSpace, but this allows many strange Unicode characters. Review this parsing code and update it to be more accurate.

@Tratcher
Copy link
Member Author

Tratcher commented Dec 8, 2014

Query string parsing also uses this code path and needs validation.

@Tratcher Tratcher modified the milestones: 1.0.0-beta2, 1.0.0-beta3 Jan 12, 2015
@Tratcher Tratcher modified the milestones: 1.0.0-rc1, 1.0.0-beta3 Jan 21, 2015
@Tratcher Tratcher assigned muratg and unassigned Tratcher Jan 21, 2015
@muratg muratg modified the milestones: 1.0.0-beta5, 1.0.0-beta4 Mar 20, 2015
@muratg muratg assigned Praburaj and unassigned muratg Mar 20, 2015
@Praburaj Praburaj removed their assignment Apr 21, 2015
@davidfowl davidfowl modified the milestones: 1.0.0-beta6, 1.0.0-beta5 Jun 11, 2015
@davidfowl
Copy link
Member

Moving this to beta6

@Tratcher Tratcher modified the milestones: 1.0.0-beta7, 1.0.0-beta6 Jun 12, 2015
@muratg muratg modified the milestones: 1.0.0-beta8, 1.0.0-beta7 Jul 28, 2015
@glennc
Copy link
Member

glennc commented Aug 24, 2015

Is this something that @blowdart should care about?

@blowdart
Copy link
Member

Yea, I'd like to see the PR when it's done, although if you're narrowing to just space and tab I'm not so concerned.

It is worth reviewing where other things call IsWhiteSpace when parsing user input.

@Eilon Eilon modified the milestones: 1.0.0 backlog, 1.0.0-beta8 Aug 27, 2015
@Tratcher Tratcher removed their assignment Nov 24, 2015
@muratg muratg modified the milestones: Backlog, 1.0.0 backlog Dec 11, 2015
@muratg
Copy link

muratg commented Dec 11, 2015

Moving out of V1. We're open to PRs @blowdart :)

@blowdart
Copy link
Member

Yea, we all know you don't want me issuing PRs for anything other than Docs 👍

@aspnet-hello
Copy link

This issue was moved to dotnet/aspnetcore#2733

@aspnet aspnet locked and limited conversation to collaborators Jan 2, 2018
@aspnet-hello aspnet-hello removed this from the Backlog milestone Jan 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

8 participants