Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

ApiReview: Move WebSocket APIs to HttpContext.WebSockets #267

Closed
Tratcher opened this issue Apr 14, 2015 · 3 comments
Closed

ApiReview: Move WebSocket APIs to HttpContext.WebSockets #267

Tratcher opened this issue Apr 14, 2015 · 3 comments
Assignees
@Tratcher
Labels
3 - Done enhancement
Milestone
1.0.0-beta5

Comments

@Tratcher
Copy link
Member 

WebSocketRequestedProtocols { get; }
AcceptWebSocketAsync()
AcceptWebSocketAsync(string subProtocol)

But not IsWebSocketRequest { get; }
@Tratcher Tratcher self-assigned this Apr 14, 2015
@Tratcher Tratcher added this to the 1.0.0-beta5 milestone Apr 14, 2015
@Tratcher
Copy link
Member Author

I think it makes sense to also move IsWebSocketRequest in with everything else. Just accessing HttContext.WebSockets doesn't imply any operations. Compare to HttpContext.Authentication.

@davidfowl
Copy link
Member

context.WebSockets.IsWebSocketRequest? /cc @lodejard

@Tratcher
Copy link
Member Author

Also do with #273 for IWebSocketAcceptContext.

Tratcher added a commit that referenced this issue Apr 21, 2015
@Tratcher
#267, #273, Move WebSocket APIs to their own object, fix context object.
2577c16
@Tratcher Tratcher mentioned this issue Apr 21, 2015
Merged
Tratcher added a commit that referenced this issue Apr 23, 2015
@Tratcher
#267, #273, Move WebSocket APIs to their own object, fix context object.
0ed2692
@Tratcher Tratcher removed the 3 - Done label Apr 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tratcher Tratcher

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta5
Development

No branches or pull requests
3 participants
@davidfowl @Tratcher @danroth27