Added OnResponseCompleted to HttpResponse #196

ajaybhargavb · 2015-02-19T22:43:56Z

Issue #160 @lodejard @Tratcher @GrabYourPitchforks

ajaybhargavb · 2015-02-19T22:46:37Z

src/Microsoft.AspNet.Http.Core/DefaultHttpResponse.cs

@@ -6,9 +6,6 @@
 using System.IO;
 using System.Linq;
 using System.Security.Claims;
-using System.Text;
-using System.Threading.Tasks;
-using Microsoft.AspNet.Http;


Removed unnecessary usings.

kevinchalet · 2015-02-20T12:22:12Z

src/Microsoft.AspNet.Owin/OwinFeatureCollection.cs

@@ -155,6 +155,16 @@ void IHttpResponseFeature.OnSendingHeaders(Action<object> callback, object state
            register(callback, state);
        }

+        void IHttpResponseFeature.OnResponseCompleted(Action<object> callback, object state)


You may also want to expose it in the OWIN environment like OnSendingHeaders: https://github.com/aspnet/HttpAbstractions/blob/response-feature/src/Microsoft.AspNet.Owin/OwinEnvironment.cs#L64

This?

HttpAbstractions/src/Microsoft.AspNet.Owin/OwinFeatureCollection.cs

Lines 150 to 158 in 08ddbe8

void IHttpResponseFeature.OnSendingHeaders(Action<object> callback, object state)

{

var register = Prop<Action<Action<object>, object>>(OwinConstants.CommonKeys.OnSendingHeaders);

if (register == null)

{

throw new NotSupportedException(OwinConstants.CommonKeys.OnSendingHeaders);

}

register(callback, state);

}

Nah, the code you pointed supports calling the server.OnSendingHeaders callback from ASP.NET 5, but can't inject server.OnSendingHeaders in the OWIN environment, which is what the OwinEnvironment class does.

Anyway, @Tratcher said they were only using community defined keys.

kevinchalet · 2015-02-20T12:27:22Z

Have you considered making this new hook async?

Related discussion (concerning OSH): aspnet/Security#76

davidfowl · 2015-02-22T04:53:42Z

src/Microsoft.AspNet.Owin/OwinConstants.cs

@@ -70,6 +70,7 @@ internal static class CommonKeys
            public const string AppName = "host.AppName";
            public const string Capabilities = "server.Capabilities";
            public const string OnSendingHeaders = "server.OnSendingHeaders";
+            public const string OnResponseCompleted = "server.OnResponseCompleted";


I'm not sure this is a key http://owin.org/spec/spec/CommonKeys.html

lodejard · 2015-03-04T22:35:36Z

davidfowl · 2015-03-05T04:33:49Z

@ajaybhargavb rebase this

ajaybhargavb · 2015-03-05T04:44:10Z

Rebased.

davidfowl · 2015-03-05T04:49:49Z

ajaybhargavb · 2015-03-05T04:50:56Z

Can you also look at all the related PRs?

ghost added the cla-not-required label Feb 19, 2015

ajaybhargavb reviewed Feb 19, 2015
View reviewed changes

This was referenced Feb 19, 2015

Implementing OnResponseCompleted in TestHost aspnet/Hosting#165

Merged

Implementing OnResponseCompleted aspnet/KestrelHttpServer#64

Merged

kevinchalet reviewed Feb 20, 2015
View reviewed changes

davidfowl reviewed Feb 22, 2015
View reviewed changes

ajaybhargavb mentioned this pull request Feb 23, 2015

Implemented OnResponseCompleted aspnet/HttpSysServer#92

Merged

ajaybhargavb force-pushed the response-feature branch from fef2113 to 0d8af4a Compare March 5, 2015 04:43

ajaybhargavb mentioned this pull request Mar 10, 2015

Register object/stream for dispose in ObjectResult and FileStreamResult aspnet/Mvc#2150

Merged

ajaybhargavb force-pushed the response-feature branch 2 times, most recently from 390f310 to ee016e1 Compare March 16, 2015 22:13

[Fixes #160] Added OnResponseCompleted to HttpResponse

f637027

ajaybhargavb force-pushed the response-feature branch from ee016e1 to f637027 Compare March 16, 2015 22:51

ajaybhargavb merged commit f637027 into dev Mar 17, 2015

Tratcher deleted the response-feature branch May 6, 2015 17:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added OnResponseCompleted to HttpResponse #196

Added OnResponseCompleted to HttpResponse #196

ajaybhargavb commented Feb 19, 2015

ajaybhargavb Feb 19, 2015

kevinchalet Feb 20, 2015

khellang Mar 17, 2015

kevinchalet Mar 17, 2015

kevinchalet commented Feb 20, 2015

davidfowl Feb 22, 2015

lodejard commented Mar 4, 2015

davidfowl commented Mar 5, 2015

ajaybhargavb commented Mar 5, 2015

davidfowl commented Mar 5, 2015

ajaybhargavb commented Mar 5, 2015

	void IHttpResponseFeature.OnSendingHeaders(Action<object> callback, object state)
	{
	var register = Prop<Action<Action<object>, object>>(OwinConstants.CommonKeys.OnSendingHeaders);
	if (register == null)
	{
	throw new NotSupportedException(OwinConstants.CommonKeys.OnSendingHeaders);
	}
	register(callback, state);
	}

Added OnResponseCompleted to HttpResponse #196

Added OnResponseCompleted to HttpResponse #196

Conversation

ajaybhargavb commented Feb 19, 2015

ajaybhargavb Feb 19, 2015

Choose a reason for hiding this comment

kevinchalet Feb 20, 2015

Choose a reason for hiding this comment

khellang Mar 17, 2015

Choose a reason for hiding this comment

kevinchalet Mar 17, 2015

Choose a reason for hiding this comment

kevinchalet commented Feb 20, 2015

davidfowl Feb 22, 2015

Choose a reason for hiding this comment

lodejard commented Mar 4, 2015

davidfowl commented Mar 5, 2015

ajaybhargavb commented Mar 5, 2015

davidfowl commented Mar 5, 2015

ajaybhargavb commented Mar 5, 2015