Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Reduce UriHelper to static methods. #300

Merged
merged 1 commit into from
May 4, 2015
Merged

Reduce UriHelper to static methods. #300

merged 1 commit into from
May 4, 2015

Conversation

Tratcher
Copy link
Member

@ghost ghost added the cla-already-signed label Apr 30, 2015
@Tratcher
Copy link
Member Author

@muratg @davidfowl

davidfowl
davidfowl reviewed Apr 30, 2015
View reviewed changes
src/Microsoft.AspNet.Http.Extensions/UriHelper.cs
}

public static string Create(PathString pathBase,
public static string Encode(PathString pathBase,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc comment? What does this do exactly

@Tratcher
Copy link
Member Author

Tratcher commented May 4, 2015

Updated.

muratg
muratg reviewed May 4, 2015
View reviewed changes
src/Microsoft.AspNet.Http.Extensions/UriHelper.cs
public static string Create(PathString pathBase,
/// <summary>
/// Combines the given uri components into a string that is properly encoded for use in HTTP headers.
/// </summary>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc nit: lowercase "uri" should probably be URI (or Uri)

@muratg
Copy link

muratg commented May 4, 2015

:shipit:

@Tratcher Tratcher force-pushed the chrross/urihelper branch from 1ad72bf to 568d0d9 Compare May 4, 2015 17:30
@Tratcher Tratcher merged commit 568d0d9 into dev May 4, 2015
@Tratcher Tratcher deleted the chrross/urihelper branch May 4, 2015 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tratcher @muratg @davidfowl