This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Make more properties settable #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,7 @@ namespace Microsoft.AspNet.Http.Internal | |||
| { | |||
| internal static class Constants | |||
| { | |||
| internal const string Http = "HTTP"; | |||
There was a problem hiding this comment.
Any good reason why these are all caps?
There was a problem hiding this comment.
No, they should probably be lower case per spec.
There was a problem hiding this comment.
Yeah it looks wrong with caps... fix here I guess? Or new PR? Up to you.
|
Updated. |
| /// Creates a query string composed from the given name value pairs. | ||
| /// </summary> | ||
| /// <param name="parameters"></param> | ||
| /// <returns></returns> |
|
Nit: Test names have a little bit of inconsistency, but not a big deal. After addressing other comments, |
…uery, Cookies).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#272 (Items, RequestAborted, IsHttps, Query, Cookies).
That should cover everything but Session which cannot be easily set with it's current design.
@muratg @davidfowl