Reduce IFeatureCollection surface area. #356
Conversation
|
Does this break other repos? |
|
Just the servers, and those should be easy to fix. |
| } | ||
| public bool Equals(KeyValuePair<Type, object> x, KeyValuePair<Type, object> y) | ||
| { | ||
| return x.Key.Equals(y.Key); |
There was a problem hiding this comment.
Just comparing keys is enough to call these "Equals"? It feels a little weird, i.e. {"x":1} and {"x":2} would be equal per this.
There was a problem hiding this comment.
This is only used on line 77 to filter out features that exist in both collections, so we only want to match by key.
There was a problem hiding this comment.
It's public. It may only be used by this class for that purpose, but what if others choose to use it?
There was a problem hiding this comment.
No, the KeyComparer class is private.
|
Updated to lazy initialize the feature storage. In the average case we'll only be reading from the default/fallback, not making changes. |
|
@Eilon to review, but we don't want to check in the break until we get Helios building again. |
|
|
from me. If you wanted to avoid breaking changes you could probably keep the
|
@Eilon it doesn't matter if I break Helios now, Andrew checked in a breaking change to ILibraryManager on Friday so the old Helios assemblies won't run anymore. |
|
@Tratcher thanks, I'm fine either way. |
|
FYI: Updated WebListener to use the same style static feature collection as Helios: aspnet/HttpSysServer@e69cb5c |
#339
@muratg @lodejard @ardalis @davidfowl