This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Add HttpReqeuest GetEncodedUrl and GetDecodedUrl extensions. #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <returns></returns> | ||
| public static string GetDecodedUrl(this HttpRequest request) | ||
| { | ||
| return request.Scheme + "://" + request.Host.Value + request.PathBase.Value + request.Path.Value + request.QueryString.Value; |
There was a problem hiding this comment.
Does all this concatenation work when some sections are missing? E.g. no query string or empty path etc.?
There was a problem hiding this comment.
Yes. Added tests for empty params.
Tratcher
force-pushed
the
tratcher/GetUrl
branch
from
dabddb6 to
7be5846
Compare
|
Also commented in the bug:
|
|
Renamed GetDecodedUrl to GetDisplayUrl. |
| @@ -71,5 +71,27 @@ public static string Encode(Uri uri) | |||
| return uri.GetComponents(UriComponents.SerializationInfoString, UriFormat.UriEscaped); | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Returns the combine components of the request URL in a fully escaped form suitable for use in HTTP headers | |||
|
|
after the comment fix.
Tratcher
force-pushed
the
tratcher/GetUrl
branch
from
b02655f to
9c3a391
Compare
Tratcher
added a commit
that referenced
this pull request
Sep 30, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#341
@davidfowl @Eilon