Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Add owin.RequestUser #376

Merged
merged 2 commits into from
Aug 21, 2015
Merged

Add owin.RequestUser #376

merged 2 commits into from
Aug 21, 2015

Conversation

khellang
Copy link
Contributor

The key owin.RequestUser was voted on and accepted as part of owin/owin#9, and has been added to the spec under Section 3.2.1 Request Data.

This PR adds the key to the environment and feature collection ✨

The property will set both server.User and owin.RequestUser, as well as fall back from owin.RequestUser to server.User on retrieval, for interoperability reasons.

@dnfclas
Copy link

dnfclas commented Aug 19, 2015

Hi @khellang, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@Tratcher
Copy link
Member

:shipit:

@Tratcher Tratcher self-assigned this Aug 21, 2015
@Tratcher Tratcher added this to the 1.0.0-beta8 milestone Aug 21, 2015
@Tratcher Tratcher added the bug label Aug 21, 2015
@davidfowl
Copy link
Member

Travis is failing

@davidfowl
Copy link
Member

@khellang can you rebase this on top of dev, we fixed the ci.

@khellang
Copy link
Contributor Author

Hmm. Rebased, but still failing. Seems unrelated tho 😕

@davidfowl
Copy link
Member

Yea that one is a known issue.

@davidfowl davidfowl added enhancement and removed bug labels Aug 21, 2015
davidfowl added a commit that referenced this pull request Aug 21, 2015
@davidfowl davidfowl merged commit 6ba7793 into aspnet:dev Aug 21, 2015
@khellang khellang deleted the owin-request-user branch August 21, 2015 08:58
@damianh
Copy link

damianh commented Aug 21, 2015

👍 good stuff

@davidfowl
Copy link
Member

@khellang Thanks for the PR!

@khellang
Copy link
Contributor Author

NP 👍 I have another one cooking for the "official" BuildFunc at dev...khellang:build-func (though it hasn't been finalized yet).

There needs to be a way for OWIN middleware to access the startup properties, and the current AddMiddleware delegate doesn't cut it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants