This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Update MediaTypeHeaderValue.IsSubsetOf() to perform consistent checks
#438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- aspnet/Mvc#3138 part 1/2 - check parameters with same polarity as type and subtype - ignore quality factors - bug was obscured because MVC has no formatters supporting wildcard media types nits: - add doc comments - spelling - correct typo in a `project.json` file
| if (Parameters != null) | ||
| // "text/plain; charset=utf-8; level=1" is a subset of "text/plain; charset=utf-8". In turn | ||
| // "text/plain; charset=utf-8" is a subset of "text/plain". | ||
| if (otherMediaType._parameters != null && otherMediaType.Parameters.Count != 0) |
There was a problem hiding this comment.
It's weird to mix fields and properties here. Pick one.
There was a problem hiding this comment.
🆗 will use the field because first reference to the property will allocate.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nits:
project.jsonfile