Promote IFormFile extension methods #534

khellang · 2016-01-13T12:44:48Z

One alternative to fix half of #527 ✨

davidfowl · 2016-01-13T12:46:08Z

src/Microsoft.AspNet.Http/Features/FormFile.cs

 using Microsoft.AspNet.Http.Internal;

 namespace Microsoft.AspNet.Http.Features.Internal
 {
    public class FormFile : IFormFile
    {
+        // Stream.CopyTo method uses 80KB as the default buffer size.
+        private const int DefaultBufferSize = 80*1024;


davidfowl · 2016-01-13T12:49:07Z

src/Microsoft.AspNet.Http/Features/FormFile.cs

+        /// <param name="cancellationToken"></param>
+        public async Task SaveAsAsync(string path, CancellationToken cancellationToken)
+        {
+            using (var fileStream = new FileStream(path, FileMode.Create))


Use File.Create instead

davidfowl · 2016-01-13T12:49:14Z

src/Microsoft.AspNet.Http/Features/FormFile.cs

+        /// <param name="path">The path of the file to create.</param>
+        public void SaveAs(string path)
+        {
+            using (var fileStream = new FileStream(path, FileMode.Create))


Use File.Create instead

davidfowl · 2016-01-13T12:53:37Z

I like it

davidfowl · 2016-01-13T12:56:47Z

src/Microsoft.AspNet.Http.Abstractions/IFormFile.cs

+        /// </summary>
+        /// <param name="path">The path of the file to create.</param>
+        /// <param name="cancellationToken"></param>
+        Task SaveAsAsync(string path, CancellationToken cancellationToken);


The pattern we chose for cancellation token was to:

Task SaveAsAsync(string path, CancellationToken cancellationToken = default(CancellationToken)));

Aigh. I thought optional params were frowned upon 😦

They are generally but https://github.com/aspnet/Home/wiki/Engineering-guidelines#async-method-patterns

davidfowl · 2016-01-13T13:05:31Z

@khellang squash the commits and I'll merge it. Let's see what breaks!

khellang · 2016-01-13T13:07:52Z

Done ✨

khellang · 2016-01-13T13:08:22Z

Let's see what breaks!

I guess this warrants an announcement?

davidfowl · 2016-01-13T13:11:18Z

src/Microsoft.AspNet.Http/Features/FormFile.cs

+        /// <param name="cancellationToken"></param>
+        public async Task SaveAsAsync(string path, CancellationToken cancellationToken = default(CancellationToken))
+        {
+            using (var fileStream = File.Create(path, DefaultBufferSize))


Almost done. You need to pass FileOptions and pass the async flag.

Promote IFormFile extension methods

dnfclas added the cla-already-signed label Jan 13, 2016