This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Promote IFormFile extension methods #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khellang
force-pushed
the
save-form-file
branch
2 times, most recently
from
f5df67e to
c7779ff
Compare
khellang
force-pushed
the
save-form-file
branch
from
c7779ff to
60f2175
Compare
khellang
force-pushed
the
save-form-file
branch
from
60f2175 to
5c5666e
Compare
Member
|
I like it |
Member
There was a problem hiding this comment.
The pattern we chose for cancellation token was to:
Task SaveAsAsync(string path, CancellationToken cancellationToken = default(CancellationToken)));
Contributor
Author
There was a problem hiding this comment.
Aigh. I thought optional params were frowned upon 😦
Member
There was a problem hiding this comment.
khellang
force-pushed
the
save-form-file
branch
from
619fde9 to
8e6dda3
Compare
Member
|
@khellang squash the commits and I'll merge it. Let's see what breaks! |
khellang
force-pushed
the
save-form-file
branch
from
8e6dda3 to
009cf4a
Compare
Contributor
Author
|
Done ✨ |
Contributor
Author
I guess this warrants an announcement? |
Member
There was a problem hiding this comment.
Almost done. You need to pass FileOptions and pass the async flag.
khellang
force-pushed
the
save-form-file
branch
from
009cf4a to
4b64d18
Compare
davidfowl
added a commit
that referenced
this pull request
Jan 13, 2016
Promote IFormFile extension methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One alternative to fix half of #527 ✨