This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Remove '+' replacement from request cookies. #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also check the parser for the forms? |
| { | ||
| get | ||
| { | ||
| // key, value, object pool, expected |
There was a problem hiding this comment.
Woops, copied from the response cookies test... Removed.
|
Hopefully this issue won't resurface? #535 |
|
We should have tests for anything previously fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#547 @muratg @BrennanConroy
When un-escaping cookies there is an extra step that replaces
+with