This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Closed
Conversation
Contributor
Author
|
ApiCheck issues |
Contributor
Author
|
Related to call costs #811 |
Contributor
Author
|
Before After Affects the uncached calls; didn't seem to really improve general call chain otherwise 😢 May need yet to be implmented devirualization/inlines |
Contributor
Author
Contributor
Author
davidfowl
reviewed
Apr 11, 2017
| namespace Microsoft.AspNetCore.Http.Performance | ||
| { | ||
| [Config(typeof(CoreConfig))] | ||
| public class DefaultContextBenchmark |
Member
There was a problem hiding this comment.
I would commit these separately.
Contributor
Author
There was a problem hiding this comment.
Sorta; will get rid of the extras
Contributor
Author
|
|
|
@benaadams is this an experimentation or a WIP for an actual change? :) |
Contributor
Author
|
Was an actual change; let me work out what it was doing again... |
Contributor
Author
|
I'll close and reopen :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


get_VersionIHttpRequestFeatureandIHttpResponseFeaturewhile creating the contextAdditionally there are compromises in
DefaultHttpXxxfor pooling; however this can be achieved without these compromises as well as improving the call chains to support devirtualization https://github.com/dotnet/coreclr/issues/9908.PooledHttpContextthoughDefaultHttpContextrather than via inheritance.DefaultHttpXxxtypes to support devirtualization of overriden methodsDefaultHttpXxxprivate members direct types rather than parent types to support devirtualizationDefaultHttpXxx.ctorsDefaultHttpXxxnon-virtualNon-DefaultHttpXxx can still be archived by inheriting from
HttpXxxand either implementing via wrappingDefaultHttpXxxas per the Pooling example to make use of the feature caches; or by doing something alternative and using a completely different implementation.