This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Add CookieBuilder #882
Merged
Add CookieBuilder #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Jun 29, 2017
HaoK
reviewed
Jun 29, 2017
| /// <param name="context">The <see cref="HttpContext"/>.</param> | ||
| /// <param name="now">The time to use as the base for computing <seealso cref="CookieOptions.Expires" /></param> | ||
| /// <returns>The cookie options.</returns> | ||
| public virtual CookieOptions Build(HttpContext context, DateTimeOffset now) |
There was a problem hiding this comment.
Can we call this expiresFrom or something similar instead of now?
There was a problem hiding this comment.
yeah, that's a little better. Updated.
HaoK
approved these changes
Jun 29, 2017
natemcmaster
force-pushed
the
namc/cookie-builder
branch
from
3c9512d to
f9e0439
Compare
This was referenced Jun 29, 2017
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #853
cc @HaoK @javiercn