This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Preserve secure and httponly headers in ResponseCookies #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Jul 17, 2017
| @@ -6,6 +6,7 @@ | |||
| using Microsoft.Extensions.ObjectPool; | |||
| using Microsoft.Net.Http.Headers; | |||
| using Xunit; | |||
| using System; | |||
There was a problem hiding this comment.
sort System goes first. There's a VS setting for this.
|
@Tratcher Tested on a real application and the secure and httponly headers are preserved. |
Tratcher
approved these changes
Aug 10, 2017
| @@ -129,6 +129,8 @@ public void Delete(string key, CookieOptions options) | |||
| Path = options.Path, | |||
| Domain = options.Domain, | |||
| Expires = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc), | |||
| Secure = options.Secure, | |||
| HttpOnly = options.HttpOnly | |||
There was a problem hiding this comment.
Add the new SameSite option as well.
jkotalik
force-pushed
the
jkotalik/ResponseCookies
branch
from
88b47e1 to
6dd8424
Compare
jkotalik
added a commit
that referenced
this pull request
Aug 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#541 @Tratcher
I would like to manually verify the before and after of this change in the response cookie, @Tratcher can you help me set that up?