Skip to content
This repository was archived by the owner on Mar 19, 2019. It is now read-only.

Force 8-byte alignment on HTTP_REQUEST buffer #203

Merged
merged 1 commit into from
Jun 22, 2016
Merged

Conversation

moozzyk
Copy link
Contributor

@moozzyk moozzyk commented Jun 15, 2016

Addresses #126

private UnsafeNclNativeMethods.HttpApi.HTTP_REQUEST* _memoryBlob;
private IntPtr _originalBlobAddress;
private byte[] _backingBuffer;
private int _offset;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_bufferAlignment

@moozzyk moozzyk force-pushed the pawelka/8bytealigned branch from 1b43c5e to 251e784 Compare June 17, 2016 00:37
@moozzyk
Copy link
Contributor Author

moozzyk commented Jun 17, 2016

🆙📅

}
}

internal static SocketAddress GetLocalEndPoint(byte[] memoryBlob, IntPtr originalAddress)
internal static SocketAddress GetLocalEndPoint(byte[] memoryBlob, int requestOffset, IntPtr originalAddress)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this all be a lot cleaner if these were instance methods on NativeRequestContext? That's where all of these parameters come from, and it looks like most of the callers have access to the context.

Do you want to try it now, or file a bug for followup?

@Tratcher
Copy link
Member

:shipit:

@moozzyk moozzyk force-pushed the pawelka/8bytealigned branch from 251e784 to f63e53b Compare June 22, 2016 17:51
@moozzyk moozzyk merged commit f63e53b into dev Jun 22, 2016
@moozzyk moozzyk deleted the pawelka/8bytealigned branch June 22, 2016 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants