This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Force 8-byte alignment on HTTP_REQUEST buffer #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private UnsafeNclNativeMethods.HttpApi.HTTP_REQUEST* _memoryBlob; | ||
| private IntPtr _originalBlobAddress; | ||
| private byte[] _backingBuffer; | ||
| private int _offset; |
moozzyk
force-pushed
the
pawelka/8bytealigned
branch
from
1b43c5e to
251e784
Compare
|
🆙📅 |
| } | ||
| } | ||
|
|
||
| internal static SocketAddress GetLocalEndPoint(byte[] memoryBlob, IntPtr originalAddress) | ||
| internal static SocketAddress GetLocalEndPoint(byte[] memoryBlob, int requestOffset, IntPtr originalAddress) |
There was a problem hiding this comment.
Would this all be a lot cleaner if these were instance methods on NativeRequestContext? That's where all of these parameters come from, and it looks like most of the callers have access to the context.
Do you want to try it now, or file a bug for followup?
|
|
moozzyk
force-pushed
the
pawelka/8bytealigned
branch
from
251e784 to
f63e53b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #126