This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Cache the ContentLength header value #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
reviewed
Jan 19, 2017
| { | ||
| private long? _contentLength; | ||
| private StringValues _contentLengthText; |
There was a problem hiding this comment.
Curious why this is kept as a StringValues? We will only store it when its count is 1 so why not store the string instead?
There was a problem hiding this comment.
We check it against the raw header StringValues and this avoids the extra conversions
|
There are quite a few tests for Content-Length already. I'll try some perf metrics today. |
|
Before: 100K requests in 28.05s After: 100K requests in 27.43s |
|
It could use a targeted test around making sure the string and long stay in sync when the value is changed / removed. |
Tratcher
force-pushed
the
tratcher/contentlength
branch
from
91396d1 to
119945c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aspnet/HttpAbstractions#757
I've also removed an obsolete layer of abstraction around the headers (HeaderDictionary) as a result of the prior package merge.