Correct targets in IISIntegration.sln and remove TestSites workaround #334
Conversation
- not clear either change will clean up CI failures on Win7 and Win2008 but can't hurt - don't see other likely suspects - dotnet/sdk#396 has been fixed; web sites target x86 automatically nit: sort dependencies
|
Small follow-up to your build changes @natemcmaster
|
|
On Win8+ we test the bin deployed ANCM. On Win7 we test the installed ANCM. |
|
@Tratcher will this change help the CI failures? Worthwhile cleanup either way. But, we need to get past this point in the test runs. |
|
No idea |
IISIntegration.sln
Outdated
| {E4E2BDC4-A9C6-4AE9-B429-032EC83EDE64}.Debug|x64.Build.0 = Debug|x64 | ||
| {E4E2BDC4-A9C6-4AE9-B429-032EC83EDE64}.Debug|x86.ActiveCfg = Debug|x86 | ||
| {E4E2BDC4-A9C6-4AE9-B429-032EC83EDE64}.Debug|x86.Build.0 = Debug|x86 | ||
| {E4E2BDC4-A9C6-4AE9-B429-032EC83EDE64}.Debug|x64.ActiveCfg = Debug|Any CPU |
There was a problem hiding this comment.
Can you undo this change? Mixing x64 and AnyCPU configurations in the solution file may lead to build/test errors.
There was a problem hiding this comment.
VS did this. Also this change /removes/ x64 by mapping it to AnyCPU.
There was a problem hiding this comment.
Yeah, the new project system in VS is super buggy when it comes to solution configurations. They're working on a fixing it in the next update. dotnet/project-system#694
There was a problem hiding this comment.
Talked offline and I'm removing the x64 / x86 configurations from the solution. Testing now.
test/TestSites/TestSites.csproj
Outdated
|
|
||
| <Import Project="..\..\build\common.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netcoreapp1.1;net452</TargetFrameworks> | ||
| <TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp1.1</TargetFrameworks> | ||
| <RuntimeIdentifiers>win7-x64;win7-x86;osx.10.10-x64;osx.10.11-x64;osx.10.12-x64;ubuntu.14.04-x64;ubuntu.15.04-x64</RuntimeIdentifiers> | ||
| <!-- TODO remove when https://github.com/dotnet/sdk/issues/396 is resolved --> | ||
| <RuntimeIdentifier Condition=" '$(TargetFramework)' != 'netcoreapp1.1' ">win7-x64</RuntimeIdentifier> | ||
| <OutputType>Exe</OutputType> |
There was a problem hiding this comment.
Nit: you can also remove OutputType. It is the default for Microsoft.NET.Sdk.Web projects.
|
🆙📅 |
nit: sort dependencies