This repository was archived by the owner on Dec 20, 2018. It is now read-only.
Upgrade projects to netcoreapp3.0 #2072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade dependencies * Change TFM on Microsoft.AspNetCore.Identity to netcoreapp3.0 * Remove .NET Framework tests
HaoK
approved these changes
Nov 16, 2018
|
Whoa, lots of test failures. Are these already known issues @HaoK? |
Does the 3.0 Sdk no longer generate a deps file? |
This sounds like something @ryanbrandenburg was investigating. Is this the issue you were seeing, Ryan? |
|
I don't recall having missing deps.json files. |
|
This might have been it: 43bae5e Tests pass locally now. |
|
Yup, that was me. Mea culpa, missed one line. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Part of dotnet/aspnetcore#3754