Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Enable ApiCheck for Socket Transport #2175

Closed
halter73 opened this issue Nov 20, 2017 · 2 comments
Closed

Enable ApiCheck for Socket Transport #2175

halter73 opened this issue Nov 20, 2017 · 2 comments
Assignees
@JunTaoLuo
Labels
3 - Done task
Milestone
2.2.0

Comments

@halter73
Copy link
Member

https://github.com/aspnet/KestrelHttpServer/pull/2173/files#r151965500
@halter73 halter73 mentioned this issue Nov 20, 2017
Merged
@muratg muratg added this to the 2.2.0 milestone Nov 27, 2017
@muratg muratg added the task label Sep 19, 2018
@muratg
Copy link
Contributor

muratg commented Sep 19, 2018

Let's just turn it on and see what happens.

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Sep 26, 2018 •
edited
Loading

Looks like we have ApiCheck enabled for all of the Kestrel packages as part of #2350. However, it looks like the base lines are out of date since they were last updated to 2.0. We should set the baselines at 2.1 and then see whether anything changed for 2.2

@JunTaoLuo JunTaoLuo mentioned this issue Sep 27, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done task
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@halter73 @muratg @JunTaoLuo