Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Reenable ApiCheck when fixed #2350

Closed
pakrym opened this issue Feb 27, 2018 · 5 comments
Closed

Reenable ApiCheck when fixed #2350

pakrym opened this issue Feb 27, 2018 · 5 comments
Assignees
@JunTaoLuo
Labels
3 - Done cost: XS Will take about half a day to complete task
Milestone
2.2.0-mq

Comments

@pakrym
Copy link
Contributor

pakrym commented Feb 27, 2018

aspnet/BuildTools#592
@pakrym pakrym added the bug label Feb 27, 2018
@pakrym pakrym added this to the 2.1.0-preview2 milestone Feb 27, 2018
@muratg muratg added the blocked Blocked label Mar 6, 2018
@JunTaoLuo JunTaoLuo added cost: XS Will take about half a day to complete and removed blocked Blocked labels Mar 21, 2018
@JunTaoLuo JunTaoLuo mentioned this issue Mar 23, 2018
Merged
@JunTaoLuo
Copy link
Contributor

Follow up needed in #2424

@pakrym pakrym reopened this Mar 31, 2018
@pakrym pakrym added 1 - Ready and removed 3 - Done labels Mar 31, 2018
@davidfowl
Copy link
Member

@pakrym why did you re-open this?

@pakrym
Copy link
Contributor Author

pakrym commented Apr 1, 2018

https://github.com/aspnet/KestrelHttpServer/pull/2446/files#diff-6483fde6c45c90fdfe98ca72eadfa651R10

Every time system assembly has breaking changes and package happens to reference it ApiCheck crashes and has to be disabled to then get "fixed" and re-enabled again.

@Eilon Eilon added task and removed bug labels Apr 2, 2018
@muratg muratg removed this from the 2.1.0-preview2 milestone Apr 3, 2018
@JunTaoLuo JunTaoLuo assigned JunTaoLuo and unassigned JunTaoLuo Apr 3, 2018
@JunTaoLuo JunTaoLuo added this to the 2.1.0-rc1 milestone Apr 3, 2018
@JunTaoLuo JunTaoLuo self-assigned this Apr 3, 2018
@muratg
Copy link
Contributor

muratg commented Apr 16, 2018 •
edited
Loading

@pakrym do we need anything in RC1? If so, we'll need a shiproom template filled. Otherwise, could you move it to 2.2.0-mq?

@muratg muratg removed this from the 2.1.0-rc1 milestone Apr 16, 2018
@pakrym
Copy link
Contributor Author

pakrym commented Apr 16, 2018

If we want to continue to validate API changes - yes, I don't know if it is fixed to be re-enabled.

Fix is being tracked in aspnet/BuildTools#592

@muratg muratg added this to the 2.2.0-mq milestone Apr 16, 2018
@JunTaoLuo JunTaoLuo mentioned this issue May 14, 2018
Merged
@JunTaoLuo JunTaoLuo mentioned this issue Sep 26, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done cost: XS Will take about half a day to complete task
Projects
None yet
Milestone
2.2.0-mq
Development

No branches or pull requests
5 participants
@davidfowl @Eilon @pakrym @muratg @JunTaoLuo