Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Re-enable api check for Transport.Libuv #2424

Closed
JunTaoLuo opened this issue Mar 23, 2018 · 2 comments
Closed

Re-enable api check for Transport.Libuv #2424

JunTaoLuo opened this issue Mar 23, 2018 · 2 comments
Assignees
@halter73
Labels
3 - Done bug cost: XS Will take about half a day to complete
Milestone
2.1.0-preview2

Comments

@JunTaoLuo
Copy link
Contributor

The breaking change occurred on the Create method of the public type LibuvTransportFactory. See commit: abdcb47#diff-8e432cc740c5553f64223236502c7ab1R65

I have disabled the api check for this package for now but this needs to be reverted after we discuss how we handle this breaking change.
@JunTaoLuo JunTaoLuo added this to the 2.1.0-preview2 milestone Mar 23, 2018
This was referenced Mar 23, 2018
Merged
Closed
@JunTaoLuo
Copy link
Contributor Author

Let's keep the discussion regarding LibuvTransportFactory in this issue

cc @halter73 @davidfowl @DamianEdwards @Eilon

@halter73 halter73 self-assigned this Mar 23, 2018
@davidfowl davidfowl added the cost: XS Will take about half a day to complete label Mar 24, 2018
@halter73
Copy link
Member

Fixed by #2426.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@halter73 halter73

Labels
3 - Done bug cost: XS Will take about half a day to complete
Projects
None yet
Milestone
2.1.0-preview2
Development

No branches or pull requests
3 participants
@halter73 @davidfowl @JunTaoLuo