Microsoft.AspNet.Server.KestrelTests failures on CoreCLR on Linux

[cesarblum]

Microsoft.AspNet.Server.KestrelTests.EngineTests.DisconnectingClient(testContext: TestServiceContext { AppLifetime = LifetimeNotImplemented { ApplicationStarted = (throws NotImplementedException), ApplicationStopped = (throws NotImplementedException), ApplicationStopping = (throws NotImplementedException) }, ConnectionFilter = null, DateHeaderValueManager = TestDateHeaderValueManager { }, Log = TestKestrelTrace { }, Memory = MemoryPool { Empty = [...] } }) [FAIL]
  System.PlatformNotSupportedException : Operation is not supported on this platform.
  Stack Trace:
       at System.Net.Sockets.SocketPal.Disconnect(Socket socket, SafeCloseSocket handle, Boolean reuseSocket)
       at System.Net.Sockets.Socket.Disconnect(Boolean reuseSocket)
       at Microsoft.AspNet.Server.KestrelTests.EngineTests.<DisconnectingClient>d__19.MoveNext()
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Server.KestrelTests.EngineTests.DisconnectingClient(testContext: TestServiceContext { AppLifetime = LifetimeNotImplemented { ApplicationStarted = (throws NotImplementedException), ApplicationStopped = (throws NotImplementedException), ApplicationStopping = (throws NotImplementedException) }, ConnectionFilter = NoOpConnectionFilter { }, DateHeaderValueManager = TestDateHeaderValueManager { }, Log = TestKestrelTrace { }, Memory = MemoryPool { Empty = [...] } }) [FAIL]
  System.PlatformNotSupportedException : Operation is not supported on this platform.
  Stack Trace:
       at System.Net.Sockets.SocketPal.Disconnect(Socket socket, SafeCloseSocket handle, Boolean reuseSocket)
       at System.Net.Sockets.Socket.Disconnect(Boolean reuseSocket)
       at Microsoft.AspNet.Server.KestrelTests.EngineTests.<DisconnectingClient>d__19.MoveNext()
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

[cesarblum]

This affects aspnet/Universe#304.

[muratg]

@halter73 This is weird. Do we have another API that we should be using instead? (To make this work on CoreCLR as well?)

[halter73]

This is the only place we call Socket.Disconnect:

KestrelHttpServer/test/Microsoft.AspNet.Server.KestrelTests/EngineTests.cs

Line 398 in 8f0d117

socket.Disconnect(false);

By simply removing the call and letting Dispose disconnect the socket, the test passes on both Windows and Linux.

[muratg]

👍 Let's get that in :)

[muratg]

@halter73 will you be able to check this in with any other PR going in soon?