This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Closed
Conversation
a9aea50 to
bd0fdb8
Compare
Member
|
The first commit seems like an obvious win. Nice catch. The rest is a little complicated/questionable without benchmarks for the reordering changes specifically showing a nice improvement. I think we're just going to merge the first commit and close the rest. |
Currently the header dictionary is randomly? ordered. This adds a first pass on an order
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened allocs as #1009
Don't allocate a key string (which then isn't used) for known keys. (Cuts out 42% of string allocations)
Before



After
String allocs are now only x4 higher than other things
Currently the header dictionary is randomly? ordered. This moves things around so some items are in a particular order:
Enumerator and CopyToFast in FrameResponseHeaders bail if nothing after: Connection, Date, Server, Content-Length, Transfer-Encoding (for MVC), Content-Type headers - rather than running through the full list of headers.
Full order probably needs work on the rest with frequency analysis.
@nathana1 @halter73 @CesarBS how does this compare to #829 ?
ReponseCookiesFeature and FormFeature moved to delayed allocation in aspnet/HttpAbstractions#675