This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Allocate DateHeaderValueManager byte array only once. #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Torn reads? What happens if its read while being written? |
|
@benaadams 😭 I guess I could lock but not sure we'd want that vs. allocating. |
|
Is only 29 (+ 12?) bytes a second 😄 Isn't like its 88 bytes a request or 176 MB per second aspnet/HttpAbstractions#677 at @ 2M rps |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small thing but avoids an allocation every second. That repeated allocation is not necessary since the date always has the same number of characters (format is
ddd, dd MMM yyyy HH:mm:ss GMT).cc @halter73 @mikeharder @davidfowl