This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Fix failing keep-alive timeout tests #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,23 +91,27 @@ public class KeepAliveTimeoutTests | |||
| { | |||
| using (var connection = new TestConnection(server.Port)) | |||
| { | |||
| for (var i = 0; i < 10; i++) | |||
| for (var i = 0; i < 11; i++) | |||
There was a problem hiding this comment.
Goes to 11? https://www.youtube.com/watch?v=KOO5S4vxi0o 😉
There was a problem hiding this comment.
@pakrym Ha, that's not necessary. I had it in my head that the keep-alive timeout I was using for the tests was 30s, but it's 10s. With the short delay being 3s I'd need 11 iterations to make sure I was getting past the timeout.
cesarblum
force-pushed
the
cesarbs/fix-keepalive-tests
branch
from
e63ba38 to
5b20652
Compare
|
Updated. |
|
Travis failure is unrelated. |
|
⌚ |
|
|
|
@CesarBS: I thought we decided the keepalive should apply to both requests and responses, so the original test is actually better. Is this fix temporary until the keepalive behavior can be changed? |
|
That's right, it's temporary. The timeout implementation needs to be revisited, but this keeps the CI good for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@halter73 @pakrym