-
Notifications
You must be signed in to change notification settings - Fork 523
Conversation
I think if we should do it only if it's going to be done for entire asp.net core. Also not before @halter73 change gets merged. |
To be clear, there are no plans to do it for all of aspnet core, but I don't think that should stop us from using a cleaner layout. There is at least one other repo that has already done this. Btw, this is on top off @halter73's change. |
Farewell GitHub history 😝 |
Not entirely opposed to the change but let's first get the new packages' names right ( |
I'm going to say no to this since it's inconsistent I also prefer the long names. Get the github expander plugin. |
I also adds no value and history ends up being messed up for no good reason (and yes, GitHub should fix their CSS 🤣) |
I also agree with @pakrym , if we're not doing this for all of ASP.NET Core it's pointless. Consistency is good across repos and EF for tend to be a bit different with some things done in the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not like
@davidfowl has had a change of heart. |
5c72bf5
to
3fcad08
Compare
Are we doing it for all repos? |
This kind of structure should be consistent across repos. All or none... I can only assume this breaks some tooling regexes.. |
FYI all - details begin discussed internally, but the primary motivation is continual problems with filenames that grow beyond max path issues. Not sure yet if all repos will get this treatment or not, but regardless, I want this for Kestrel as this project has particularly long filenames, eg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
This was review from months ago and without explanation.
⌚ waiting until the work on rel/2.0.0 is done. This would make it painful to merge changes in rel/2.0.0 back to dev. |
3fcad08
to
5eb8d74
Compare
Remove the Microsoft.AspNetCore.Server prefix from csproj and their folders. This is required to help us avoid max path issues on Windows.
5eb8d74
to
6584a8b
Compare
As long as we are rearranging out entire codebase...
https://github.com/aspnet/KestrelHttpServer/tree/namc/folders