Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Add Connection as a primary request header #1569

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Add Connection as a primary request header #1569

merged 1 commit into from
Mar 30, 2017

Conversation

natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Mar 29, 2017 •
edited
Loading

Resolves #1482
cc @benaadams
dev

                        Method |      Mean |    StdDev |      Op/s | Scaled | Scaled-StdDev | Allocated |
------------------------------ |---------- |---------- |---------- |------- |-------------- |---------- |
          PlaintextTechEmpower | 1.3681 us | 0.0243 us | 730914.71 |   1.00 |          0.00 |     349 B |
          PlaintextAbsoluteUri | 2.5020 us | 0.0458 us | 399688.23 |   1.83 |          0.05 |     693 B |
 PipelinedPlaintextTechEmpower | 1.2069 us | 0.0307 us | 828549.59 |   0.88 |          0.03 |     348 B |
                    LiveAspNet | 2.7951 us | 0.0431 us | 357770.44 |   2.04 |          0.05 |   1.07 kB |
           PipelinedLiveAspNet | 2.7058 us | 0.0837 us | 369572.14 |   1.98 |          0.07 |   1.07 kB |
                       Unicode | 4.6382 us | 0.0997 us | 215601.91 |   3.39 |          0.09 |   1.85 kB |
              UnicodePipelined | 4.4694 us | 0.0597 us | 223741.73 |   3.27 |          0.07 |   1.86 kB |

namc/primary-header

                        Method |      Mean |    StdDev |      Op/s | Scaled | Scaled-StdDev | Allocated |
------------------------------ |---------- |---------- |---------- |------- |-------------- |---------- |
          PlaintextTechEmpower | 1.3279 us | 0.0262 us | 753046.25 |   1.00 |          0.00 |     349 B |
          PlaintextAbsoluteUri | 2.3808 us | 0.0536 us | 420035.04 |   1.79 |          0.05 |     693 B |
 PipelinedPlaintextTechEmpower | 1.1522 us | 0.0228 us | 867933.06 |   0.87 |          0.02 |     348 B |
                    LiveAspNet | 2.8840 us | 0.4161 us | 346736.69 |   2.17 |          0.31 |   1.07 kB |
           PipelinedLiveAspNet | 2.6187 us | 0.0502 us | 381871.33 |   1.97 |          0.05 |   1.07 kB |
                       Unicode | 4.6840 us | 0.2503 us | 213493.65 |   3.53 |          0.20 |   1.85 kB |
              UnicodePipelined | 4.4318 us | 0.0819 us | 225642.36 |   3.34 |          0.09 |   1.86 kB |

@cesarblum
Copy link
Contributor

Interesting bump in plaintext. Check E2E too.

@benaadams
Copy link
Contributor

Plaintext bump is expected 😄

@natemcmaster
Copy link
Contributor Author

E2E Benchmark: -n Plaintext --kestrelThreadCount 2

dev

[02:40:03.945] RPS: 1305710.14
[02:40:20.234] RPS: 1324257.63

namc/primary-header

[02:41:15.414] RPS: 1322320.88
[02:41:31.060] RPS: 1319414.79

@natemcmaster
Copy link
Contributor Author

⌚ #1551

@natemcmaster natemcmaster added blocked Blocked and removed blocked Blocked labels Mar 29, 2017
@natemcmaster natemcmaster merged commit 6b6a834 into dev Mar 30, 2017
@natemcmaster natemcmaster deleted the namc/primary-header branch March 30, 2017 00:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cesarblum cesarblum cesarblum approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natemcmaster @cesarblum @benaadams @dnfclas