-
Notifications
You must be signed in to change notification settings - Fork 523
Frame implementing mutable IFeatureCollection #243
Conversation
@@ -19,6 +20,9 @@ public class Startup | |||
{ | |||
public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory, IApplicationEnvironment env) | |||
{ | |||
var ksi = app.ServerFeatures[typeof(IKestrelServerInformation)] as IKestrelServerInformation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app.ServerFeatures.Get<IKestrelServerInformation>()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used for anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
it's used to change ThreadCount (once that's working again)
@lodejard Could you sign the CLA? 😄 |
@muratg I have twice now... No idea why the system keeps calling me out like that! I'll sign it again. |
@lodejard, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
@@ -725,5 +728,5 @@ public bool StatusCanHaveBody(int statusCode) | |||
statusCode != 205 && | |||
statusCode != 304; | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fix indendation
|
* Sorting namespaces * Removing `as` casting for Frame's implemented interfaces
Only generate type statics for cached features
Adding this commit so the file stops showing up as modified
fd0b509
to
78177e7
Compare
Reducing allocations and avoiding dictionary operations for well-known feature interfaces