Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Frame implementing mutable IFeatureCollection #243

Merged
merged 17 commits into from
Oct 9, 2015

Conversation

lodejard
Copy link
Contributor

@lodejard lodejard commented Oct 6, 2015

Reducing allocations and avoiding dictionary operations for well-known feature interfaces

@@ -19,6 +20,9 @@ public class Startup
{
public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory, IApplicationEnvironment env)
{
var ksi = app.ServerFeatures[typeof(IKestrelServerInformation)] as IKestrelServerInformation;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app.ServerFeatures.Get<IKestrelServerInformation>()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used for anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

it's used to change ThreadCount (once that's working again)

@muratg
Copy link
Contributor

muratg commented Oct 8, 2015

@lodejard Could you sign the CLA? 😄

@lodejard
Copy link
Contributor Author

lodejard commented Oct 8, 2015

@muratg I have twice now... No idea why the system keeps calling me out like that! I'll sign it again.

@dnfclas
Copy link

dnfclas commented Oct 8, 2015

@lodejard, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@@ -725,5 +728,5 @@ public bool StatusCanHaveBody(int statusCode)
statusCode != 205 &&
statusCode != 304;
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: fix indendation

@halter73
Copy link
Member

halter73 commented Oct 9, 2015

:shipit:

@lodejard lodejard force-pushed the lodejard/featurecollection branch from fd0b509 to 78177e7 Compare October 9, 2015 20:26
@lodejard lodejard merged commit 78177e7 into dev Oct 9, 2015
@davidfowl davidfowl deleted the lodejard/featurecollection branch March 19, 2017 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants