This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Clean up flaky MaxRequestBufferSize tests #2497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
approved these changes
Apr 16, 2018
|
Blocked while branching. |
Tratcher
force-pushed
the
tratcher/buffers
branch
from
978f795 to
333586d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging #2225 and had a reliable repro before John's logging changes. After his changes I could only cause OOMs. This change addresses the OOMs and the test now reliably passes.
I also removed the data corruption validation, there's a seperate test for that. These tests are much faster without it.