Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Improve reliability of MaxRequestBufferSizeTests.LargeUpload #2586

Merged
merged 6 commits into from
May 17, 2018
Merged

Improve reliability of MaxRequestBufferSizeTests.LargeUpload #2586

merged 6 commits into from
May 17, 2018

Conversation

mikeharder
Copy link
Contributor

@mikeharder mikeharder commented May 17, 2018 •
edited
Loading

mikeharder added 5 commits May 17, 2018 13:07
@mikeharder
Increase _dataLength from 20MB to 40MB to improve test reliability
745f149 
- On Windows 10 1803, client can be paused as late as 36MB when MaxRequestBufferSize is 5MB
- Add temporary logging to measure pause location on all platforms
@mikeharder
Add pauses for Ubuntu 18.04
26cf7c5
@mikeharder
Add pauses for macOS
038cba8
@mikeharder
Remove temp logging
72df141
@mikeharder
Move comment
784e4c8
@mikeharder mikeharder requested review from halter73 and Tratcher May 17, 2018 20:12
@mikeharder
Copy link
Contributor Author

@dotnet-bot test Ubuntu 16.04 Release Build

@halter73 halter73 mentioned this pull request May 17, 2018
Closed
@mikeharder
Copy link
Contributor Author

@halter73, @Tratcher: Added pause data for MaxRequestBufferSize=1MB (the default). I don't understand why, but the Libuv and Sockets behaviors are much closer compared to MaxRequestBufferSize=5MB.

@mikeharder
Copy link
Contributor Author

@halter73, @Tratcher: OK to merge? I could file an issue to investigate why Sockets gets paused so much later than Libuv when MaxRequestBufferSize=5MB, but since the two transports have similar behavior for the default MaxRequestBufferSize=1MB, I don't think it's worth the time.

@mikeharder mikeharder merged commit 1951ddf into dev May 17, 2018
@mikeharder mikeharder deleted the mikeharder/large-upload-flaky branch May 17, 2018 23:53
This was referenced May 18, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73

Assignees

@halter73 halter73

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeharder @Tratcher @halter73