Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Don't alloc header names #391

Closed
wants to merge 2 commits into from
Closed

Conversation

benaadams
Copy link
Contributor

No description provided.

@benaadams
Copy link
Contributor Author

Split from #335

@@ -318,6 +308,36 @@ public void Abort()
}
}

private async Task<bool> ReadStartLineAsync()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moar async state machines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dodged!

@DamianEdwards
Copy link
Member

Rebased on 7e8a405 and measured. Made it worse.

dev (7e8a405) - 499k
391 (e0ebb12) - 465k (-7%)

@benaadams
Copy link
Contributor Author

@DamianEdwards hopefully it will behave better on #362

benaadams added a commit to benaadams/KestrelHttpServer that referenced this pull request Nov 24, 2015
With precomputed tasks

Hopefully aspnet#391, the good bits...
@benaadams
Copy link
Contributor Author

Closing this taken some legibility improvements to #424

@benaadams benaadams closed this Nov 24, 2015
benaadams added a commit to benaadams/KestrelHttpServer that referenced this pull request Nov 24, 2015
With precomputed tasks

Hopefully aspnet#391, the good bits...
@benaadams benaadams deleted the header-alloc branch May 10, 2016 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants