This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Don't wait to consume the entire request body for Connection: close requests #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,6 +88,37 @@ public Task RemoteIPv6Address() | |||
| return TestRemoteIPAddress("[::1]", "[::1]", "::1", "8792"); | |||
| } | |||
|
|
|||
| [ConditionalFact] | |||
| [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "Test hangs after execution on Mono.")] | |||
| public async Task DoesNotHangOnConnectionCloseRequest() | |||
There was a problem hiding this comment.
Is RequestTests the appropriate class for this test?
|
|
cesarblum
force-pushed
the
cesarbs/dont-consume-body-connection-close
branch
from
5c1c1c7 to
e4fd91b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#406
cc @halter73