This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Fixed shutdown hanging #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @lodejard |
- Added Stopping event to KestrelThread so that incoming connections get a chance to gracefully close before disposing the event loop - Call _post.Dispose instead of UnReference. Sometimes Dispose would happen on the finalizer thread and _queueCloseHandle would be null. #9
davidfowl
force-pushed
the
shutdown-issues
branch
from
bb852bf to
55d997b
Compare
|
ping |
|
@davidfowl, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incoming connections get a chance to gracefully close
before disposing the event loop
Dispose would happen on the finalizer thread and _queueCloseHandle
would be null.
Shutting the server down causes a hang #9