This repository was archived by the owner on Dec 18, 2018. It is now read-only.
MemoryPoolIterator2.Seek performance #514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var data = new Vector<byte>(array, index); | ||
| var byte0Equals = Vector.Equals(data, byte0Vector); | ||
| #endif | ||
| if (following >= _vectorSpan) |
|
Did you do any benchmarks for this change? |
|
Will revisit with #519 as source (or rather with hindsight of knowing where am going) |
|
I really like the passing as |
|
Removing the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static vectors by ref rather than by copy
Faster path when length <
Vector<byte>.CountSkip Vector path when
Vector.IsHardwareAccelerated != trueunless in debug/test (e.g. linux and x86)Linux hopefully resolved in RC2? https://github.com/dotnet/coreclr/issues/983
Resolves #512
Resolves #515