This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Faster CopyFrom(+Ascii) #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -584,52 +584,52 @@ public void CopyFrom(byte[] data) | |||
| CopyFrom(data, 0, data.Length); | |||
| } | |||
|
|
|||
| public void CopyFrom(ArraySegment<byte> buffer) | |||
There was a problem hiding this comment.
Keep the ArraySegment<byte> overload? Are you just trying to avoid copies?
benaadams
force-pushed
the
copyfrom-perf
branch
2 times, most recently
from
0bd4088 to
8bb9cea
Compare
benaadams
force-pushed
the
copyfrom-perf
branch
from
8bb9cea to
c324a27
Compare
benaadams
force-pushed
the
copyfrom-perf
branch
2 times, most recently
from
b73dc03 to
3c38f48
Compare
This was referenced Dec 29, 2015
Merged
benaadams
force-pushed
the
copyfrom-perf
branch
from
3c38f48 to
18a4713
Compare
| Debug.Assert(_block != null); | ||
| Debug.Assert(_block.Pool != null); | ||
| Debug.Assert(_block.Next == null); | ||
| Debug.Assert(_block.End == _index); |
There was a problem hiding this comment.
Any reason for removing these asserts?
benaadams
force-pushed
the
copyfrom-perf
branch
2 times, most recently
from
5fa84f4 to
af593d2
Compare
benaadams
force-pushed
the
copyfrom-perf
branch
from
af593d2 to
b88a697
Compare
benaadams
force-pushed
the
copyfrom-perf
branch
from
b88a697 to
caaf9d4
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #519