This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Remove old code #557
Closed
Remove old code #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +16,6 @@ public class SocketInput : ICriticalNotifyCompletion | |||
|
|
|||
| private readonly MemoryPool2 _memory; | |||
| private readonly IThreadPool _threadPool; | |||
| private readonly ManualResetEventSlim _manualResetEvent = new ManualResetEventSlim(false); | |||
There was a problem hiding this comment.
Removing this seems scary. I think this breaks reasonable assumptions about how GetResult() works.
|
Yeah, little bit scary. But I can't think of any situation when this is needed. And there is no test or comment why this is needed. The code is created by @lodejard |
|
I'm happy taking the first commit removing uncalled methods, but I don't see a compelling enough reason to remove |
|
Same for me. |
|
Ok, do you want me to remove the last commit? |
|
Yes, please. |
|
SocketInput's Skip and Take methods have been removed #525, and I don't want to remove the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some unused code