Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Remove old code #557

Closed
wants to merge 2 commits into from
Closed

Remove old code #557

wants to merge 2 commits into from

Conversation

Anderman
Copy link
Contributor

@Anderman Anderman commented Jan 6, 2016

Removed some unused code

@@ -17,7 +16,6 @@ public class SocketInput : ICriticalNotifyCompletion

private readonly MemoryPool2 _memory;
private readonly IThreadPool _threadPool;
private readonly ManualResetEventSlim _manualResetEvent = new ManualResetEventSlim(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this seems scary. I think this breaks reasonable assumptions about how GetResult() works.

@Anderman
Copy link
Contributor Author

Anderman commented Jan 6, 2016

Yeah, little bit scary. But I can't think of any situation when this is needed. And there is no test or comment why this is needed.

The code is created by @lodejard

@halter73
Copy link
Member

halter73 commented Jan 6, 2016

I'm happy taking the first commit removing uncalled methods, but I don't see a compelling enough reason to remove _manualResetEvent from SocketInput.

@cesarblum
Copy link
Contributor

Same for me.

@Anderman
Copy link
Contributor Author

Anderman commented Jan 8, 2016

Ok, do you want me to remove the last commit?

@cesarblum
Copy link
Contributor

Yes, please.

@halter73
Copy link
Member

halter73 commented Jan 9, 2016

SocketInput's Skip and Take methods have been removed #525, and I don't want to remove the _manualResetEvent, so I'm closing this.

@halter73 halter73 closed this Jan 9, 2016
@Anderman Anderman deleted the SocketInputCleanup branch January 9, 2016 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants