This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Debug MaxInputBufferLength failures on Travis OSX #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tests currently fail sometimes, caused by server reading more bytes than sent by client.
…sending the full number of requested bytes when a SocketException is thrown, which is not guaranteed to be true on all platforms.
- Send bytes in a background task - Block test thread until send task has gone a while without writing bytes, rather than using timeout and SocketException. - Refactor to use mostly the same code for both pause and no-pause scenarios.
- Required for connection filters, which use use two instances of SocketInput. We need to ensure the combined buffers do not exceed the limit, and to coordinate the calls to `IConnectionControl` between the two instances of SocketInput.
- Prevents breaking tests which call SocketInput.ctor()
- Add Moq to KestrelTests
Add comments explaining why each size is tested.
- HTTP requires "\r\n", and WriteLine() uses "\n" on Mac/Linux
- Reverts regression introduced in 584f314
… paused until around 10MB after the server sends backpressure.
- Blocking causes deadlock on single-core machines
mikeharder
changed the title
|
Delete? Or still investigating? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to debug MaxInputBufferLength failures on Travis OSX. Fixes will be rolled into #912.