Fix MessagePackReader for multi-segment strings #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var reader = new MessagePackReader(seq); | ||
| var result = reader.ReadString(); | ||
| Assert.Equal("AB", result); |
There was a problem hiding this comment.
Without the fix, this assertion fails, because result equals "AA" instead of "AB".
|
cc @AArnott |
AArnott
approved these changes
Apr 17, 2019
|
@AArnott I'll get this upstream next week. Merging this in so we can update this for the preview5 release. |
pranavkm
pushed a commit
that referenced
this pull request
Apr 23, 2019
* Add failing unit test to show the bug
pranavkm
pushed a commit
that referenced
this pull request
Apr 23, 2019
* Add failing unit test to show the bug
pranavkm
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Add failing unit test to show the bug
dougbu
pushed a commit
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue reported in server-side Blazor whereby it would sometimes abort connections when the server was under high traffic: dotnet/aspnetcore#6385. The SignalR hub was receiving corrupted messages, e.g., to invoke a hub method called
OnOnOnOnOnOnOnOnO(should beOnRenderCompleted).The bug is that
MessagePackReaderhas two ways of reading strings: fast path (used when the sequence reader contains only one span), and slow path (used when it has multiple spans), but only the fast path actually works. The slow path code will always produce corrupted results, because it doesn't advance the reader each time it gets some bytes from it.AFAICT there were no tests for
MessagePackReader's string handling, so I've added a couple of basic ones. However it's not my goal to create a complete test suite forMessagePackReaderin this PR, of course!