This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Tag Helpers: add code generation for `ModelExpression` instances #1241

Closed

dougbu opened this issue Oct 6, 2014 · 2 comments

Assignees

Labels

Milestone

Contributor

dougbu commented Oct 6, 2014

a tag helper such as

  <input type="text" for="Property"/>

should result in code similar to

  inputHelper.For = new ModelExpression(model => model.Property)

This work item does not include special-casing a leading @ in the expression. That will be a separate, later (post-Beta?) work item.

The text was updated successfully, but these errors were encountered:

dougbu added this to the 6.0.0-beta1 milestone

dougbu assigned NTaylorMullen

Contributor Author

dougbu commented Oct 6, 2014

#1253 covers the separate work item mentioned above

dougbu mentioned this issue

Tag Helpers: Build HtmlHelper equivalent tag helper defaults. #687

Closed

NTaylorMullen added the 2 - Working label

NTaylorMullen pushed a commit that referenced this issue


          Add ModelExpression code generation.

5d92c94

- Sealed the ModelExpression.
- We use the stringified version of the ModelExpression type name to detect ModelExpression properties on TagHelpers. This is so the MvcRazorHost can work in tooling and in runtime.
- Created a GeneratedTagHelperAttributeContext to represent the specific stringified versions of the ModelExpression assets.
- Created an MvcTagHelperAttributeValueCodeRenderer to modify rendering of ModelExpression properties.

#1241

NTaylorMullen pushed a commit that referenced this issue


          Add tests to validate attribute value rendering.

b69b7bf

- Exposed internals from Mvc.Razor.Host to Mvc.Razor.Test so it can use the MvcRazorHost override that takes the IFileSystem.
- Added end-to-end code generation tests for TagHelpers with ModelExpression properties.

#1241

NTaylorMullen mentioned this issue

Tag Helpers: Add ModelExpression code generation #1291

Closed

NTaylorMullen pushed a commit that referenced this issue


          Add ModelExpression code generation.

73101f1

- Sealed the ModelExpression.
- We use the stringified version of the ModelExpression type name to detect ModelExpression properties on TagHelpers. This is so the MvcRazorHost can work in tooling and in runtime.
- Created a GeneratedTagHelperAttributeContext to represent the specific stringified versions of the ModelExpression assets.
- Created an MvcTagHelperAttributeValueCodeRenderer to modify rendering of ModelExpression properties.

#1241

NTaylorMullen pushed a commit that referenced this issue


          Add tests to validate attribute value rendering.

4c9bce4

- Exposed internals from Mvc.Razor.Host to Mvc.Razor.Test so it can use the MvcRazorHost override that takes the IFileSystem.
- Added end-to-end code generation tests for TagHelpers with ModelExpression properties.

#1241

NTaylorMullen pushed a commit that referenced this issue


          Add ModelExpression code generation.

834edf0

- Sealed the ModelExpression.
- We use the stringified version of the ModelExpression type name to detect ModelExpression properties on TagHelpers. This is so the MvcRazorHost can work in tooling and in runtime.
- Created a GeneratedTagHelperAttributeContext to represent the specific stringified versions of the ModelExpression assets.
- Created an MvcTagHelperAttributeValueCodeRenderer to modify rendering of ModelExpression properties.

#1241

NTaylorMullen pushed a commit that referenced this issue


          Add tests to validate attribute value rendering.

b3ae381

- Exposed internals from Mvc.Razor.Host to Mvc.Razor.Test so it can use the MvcRazorHost override that takes the IFileSystem.
- Added end-to-end code generation tests for TagHelpers with ModelExpression properties.

#1241

NTaylorMullen mentioned this issue

Tag Helpers: Add ModelExpression code generation #1300

Closed

NTaylorMullen pushed a commit that referenced this issue


          Add ModelExpression code generation.

2da5d4f

- Sealed the ModelExpression.
- We use the stringified version of the ModelExpression type name to detect ModelExpression properties on TagHelpers. This is so the MvcRazorHost can work in tooling and in runtime.
- Created a GeneratedTagHelperAttributeContext to represent the specific stringified versions of the ModelExpression assets.
- Created an MvcTagHelperAttributeValueCodeRenderer to modify rendering of ModelExpression properties.

#1241

NTaylorMullen pushed a commit that referenced this issue


          Add tests to validate attribute value rendering.

0f6c981

- Exposed internals from Mvc.Razor.Host to Mvc.Razor.Test so it can use the MvcRazorHost override that takes the IFileSystem.
- Added end-to-end code generation tests for TagHelpers with ModelExpression properties.

#1241

NTaylorMullen pushed a commit that referenced this issue


          Add ModelExpression code generation.

3c64c74

- Sealed the ModelExpression.
- We use the stringified version of the ModelExpression type name to detect ModelExpression properties on TagHelpers. This is so the MvcRazorHost can work in tooling and in runtime.
- Created a GeneratedTagHelperAttributeContext to represent the specific stringified versions of the ModelExpression assets.
- Created an MvcTagHelperAttributeValueCodeRenderer to modify rendering of ModelExpression properties.

#1241

NTaylorMullen pushed a commit that referenced this issue


          Add tests to validate attribute value rendering.

9bc627f

- Exposed internals from Mvc.Razor.Host to Mvc.Razor.Test so it can use the MvcRazorHost override that takes the IFileSystem.
- Added end-to-end code generation tests for TagHelpers with ModelExpression properties.

#1241

NTaylorMullen pushed a commit that referenced this issue


          Add ModelExpression code generation.

2005c3c

- Sealed the ModelExpression.
- We use the stringified version of the ModelExpression type name to detect ModelExpression properties on TagHelpers. This is so the MvcRazorHost can work in tooling and in runtime.
- Created a GeneratedTagHelperAttributeContext to represent the specific stringified versions of the ModelExpression assets.
- Created an MvcTagHelperAttributeValueCodeRenderer to modify rendering of ModelExpression properties.

#1241

NTaylorMullen pushed a commit that referenced this issue


          Add tests to validate attribute value rendering.

75a77e2

- Exposed internals from Mvc.Razor.Host to Mvc.Razor.Test so it can use the MvcRazorHost override that takes the IFileSystem.
- Added end-to-end code generation tests for TagHelpers with ModelExpression properties.

#1241

NTaylorMullen added 3 - Done and removed 2 - Working labels

NTaylorMullen commented Oct 10, 2014

2005c3c
75a77e2

NTaylorMullen closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.