Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

PrecompilationWebSite has troubles building in VS #2498

Closed
dougbu opened this issue May 4, 2015 · 4 comments
Closed

PrecompilationWebSite has troubles building in VS #2498

dougbu opened this issue May 4, 2015 · 4 comments
Labels
duplicate

Comments

@dougbu
Copy link
Member

dougbu commented May 4, 2015

  • no problems if site built on its own
  • 10 errors if Microsoft.AspNet.Mvc.FunctionalTests or solution built
    • 8 messages are "Cannot resolve TagHelper containing assembly 'PrecompilationWebSite'. Error: Could not load file or assembly 'Microsoft.AspNet.Mvc.Core' or one of its dependencies. The system cannot find the file specified."
    • 2 messages are "Encountered an unexpected error when attempting to resolve tag helper directive '@addTagHelper' with value '*, Microsoft.AspNet.Mvc.TagHelpers'. Error: Could not load file or assembly 'Microsoft.AspNet.Mvc.Core' or one of its dependencies. The system cannot find the file specified."
dougbu added a commit that referenced this issue May 4, 2015
@dougbu
Get builds working better within VS (temporary fix?); disable pre-com…
c5f153f 
…pilation

- remove `RazorPreCompilation.cs` files from all but the PrecompilationWebSite
- related to #2498 but not addressing that issue since pre-compilation is what that site is about
@dougbu dougbu mentioned this issue May 4, 2015
Closed
@danroth27
Copy link
Member

@davidfowl @Eilon What's the plan for precompilation all up?

@danroth27 danroth27 added this to the 6.0.0-beta5 milestone May 5, 2015
@danroth27 danroth27 removed this from the 6.0.0-beta5 milestone May 5, 2015
dougbu added a commit that referenced this issue May 11, 2015
@dougbu
Get builds working better within VS (temporary fix?); disable pre-com…
3fbead0 
…pilation

- remove `RazorPreCompilation.cs` files from all but the PrecompilationWebSite
- related to #2498 but not addressing that issue since pre-compilation is what that site is about
@dougbu
Copy link
Member Author

dougbu commented May 11, 2015

See also aspnet/RazorTooling#10

@dougbu
Copy link
Member Author

dougbu commented May 11, 2015

Basically there's two ways to go from here:

  1. Fix this bug or TagHelper tooling does not work with pre-compilation enabled. RazorTooling#10 -- either should get Razor precompilation working reliably across the MVC repo. Then revert commit 3fbead0.
  2. Decide Razor precompilation is unstable and will take a significant (unbudgeted) effort to get working reliably. Then remove our support for this feature, along with the PrecompilationWebSite.

@Eilon Eilon mentioned this issue May 12, 2015
Closed
@danroth27 danroth27 added this to the 6.0.0-beta6 milestone May 14, 2015
@danroth27
Copy link
Member

#2551

@danroth27 danroth27 removed this from the 6.0.0-beta6 milestone Jun 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danroth27 @dougbu