Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Remove CodeAnnotations and related JetBrains use from client code generation source #8416

Closed
dougbu opened this issue Sep 7, 2018 · 1 comment
Assignees
Labels

Comments

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2018

Is this a Bug or Feature request?

Enhancement that's part of #7947

Description of the problem

Current source inherited CodeAnnotations from dotnet-ef. Since these annotations etc. aren't really needed and we have nothing similar in the Mvc repo, just remove the class and its use.

Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All:

See the features/client.code.generation branch branch. That work is intended for the 2.2 Preview 3 milestone.

@dougbu dougbu added enhancement 1 - Ready cost: XS Will take up to half a day to complete labels Sep 7, 2018
@dougbu dougbu added this to the 2.2.0-preview3 milestone Sep 7, 2018
@dougbu dougbu self-assigned this Sep 7, 2018
dougbu added a commit that referenced this issue Sep 10, 2018
- #8416
- turns out this required little on top of dougbu/remove.custom.tool
@dougbu
Copy link
Contributor Author

dougbu commented Sep 10, 2018

9437f29

@dougbu dougbu closed this as completed Sep 10, 2018
dougbu added a commit that referenced this issue Sep 11, 2018
- #8416
- turns out this required little on top of dougbu/remove.custom.tool
dougbu added a commit that referenced this issue Oct 4, 2018
- #8416
- turns out this required little on top of dougbu/remove.custom.tool
dougbu added a commit that referenced this issue Oct 7, 2018
- #8416
- turns out this required little on top of dougbu/remove.custom.tool
dougbu added a commit that referenced this issue Oct 7, 2018
- #8416
- turns out this required little on top of dougbu/remove.custom.tool
dougbu added a commit that referenced this issue Oct 9, 2018
- #8416
- turns out this required little on top of dougbu/remove.custom.tool
dougbu added a commit that referenced this issue Oct 10, 2018
- #8416
- turns out this required little on top of dougbu/remove.custom.tool
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant