Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Rationalize the code sharing between the three code generation projects #8417

Closed
dougbu opened this issue Sep 7, 2018 · 2 comments
Closed

Rationalize the code sharing between the three code generation projects #8417

dougbu opened this issue Sep 7, 2018 · 2 comments
Assignees
@dougbu
Labels
3 - Done cost: XS Will take up to half a day to complete enhancement feature-code-generation
Milestone
2.2.0-preview3

Comments

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2018

Is this a Bug or Feature request?

Enhancement that's part of #7947

Description of the problem

Code sharing between the code generation projects is mostly from the bottom up: GetDocumentInsider -> dotnet-getdocument -> Microsoft.Extensions.ApiDescription.Client but a couple of oddball cases exist and those links should be reversed.

In particular DownloadFileCore and ILogWrapper should be in the GetDocumentInsider project with <Compile/> links in Microsoft.Extensions.ApiDescription.Client rather than the other way around.

Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All

See the features/client.code.generation branch branch. That work is intended for the 2.2 Preview 3 milestone.
@dougbu dougbu added enhancement 1 - Ready cost: XS Will take up to half a day to complete labels Sep 7, 2018
@dougbu dougbu added this to the 2.2.0-preview3 milestone Sep 7, 2018
@dougbu dougbu self-assigned this Sep 7, 2018
dougbu added a commit that referenced this issue Sep 10, 2018
@dougbu
Rationalize code sharing between the three code generation projects
f5bdfe8 
- #8417
- just two files needed to be moved&hellip;
@dougbu dougbu mentioned this issue Sep 10, 2018
Closed
dougbu added a commit that referenced this issue Sep 10, 2018
@dougbu
Rationalize code sharing between the three code generation projects
ebd9fcb 
- #8417
- just two files needed to be moved&hellip;
@dougbu
Copy link
Contributor Author

dougbu commented Sep 10, 2018

ebd9fcb

@dougbu dougbu closed this as completed Sep 10, 2018
dougbu added a commit that referenced this issue Sep 11, 2018
@dougbu
Rationalize code sharing between the three code generation projects
792d5b4 
- #8417
- just two files needed to be moved&hellip;
@dougbu
Copy link
Contributor Author

dougbu commented Sep 11, 2018

Correct commit id 792d5b4

dougbu added a commit that referenced this issue Oct 4, 2018
@dougbu
Rationalize code sharing between the three code generation projects
aea8ebb 
- #8417
- just two files needed to be moved&hellip;
dougbu added a commit that referenced this issue Oct 7, 2018
@dougbu
Rationalize code sharing between the three code generation projects
b01bef6 
- #8417
- just two files needed to be moved&hellip;
dougbu added a commit that referenced this issue Oct 7, 2018
@dougbu
Rationalize code sharing between the three code generation projects
66553e1 
- #8417
- just two files needed to be moved&hellip;
dougbu added a commit that referenced this issue Oct 9, 2018
@dougbu
Rationalize code sharing between the three code generation projects
e305b42 
- #8417
- just two files needed to be moved&hellip;
dougbu added a commit that referenced this issue Oct 10, 2018
@dougbu
Rationalize code sharing between the three code generation projects
3f00175 
- #8417
- just two files needed to be moved&hellip;
@dougbu dougbu mentioned this issue Apr 6, 2019
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done cost: XS Will take up to half a day to complete enhancement feature-code-generation
Projects
None yet
Milestone
2.2.0-preview3
Development

No branches or pull requests
1 participant
@dougbu