Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Add batching in Microsoft.Extensions.ApiDescription.Client.targets #8419

Closed
dougbu opened this issue Sep 7, 2018 · 1 comment
Closed

Add batching in Microsoft.Extensions.ApiDescription.Client.targets #8419

dougbu opened this issue Sep 7, 2018 · 1 comment
Assignees
@dougbu
Labels
3 - Done cost: S Will take up to 2 days to complete enhancement feature-code-generation PRI: 0 - Critical Blocks a critical product path. Must be handled immediately
Milestone
2.2.0-preview3

Comments

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2018

Is this a Bug or Feature request?

Enhancement that's part of #7947

Description of the problem

The amount of MSBuild code required to implement a BlahCSharpCodeGenerator or BlahDocumentGenerator target is too high at present. Aim is to incorporate batching in our common code and reduce that burden.

The canary case will be our own DefaultDocumentGenerator. Confirm that can't be simplified further after removing the batching requirement.

Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All

See the features/client.code.generation branch branch. That work is intended for the 2.2 Preview 3 milestone.
@dougbu dougbu added enhancement 2 - Working cost: S Will take up to 2 days to complete labels Sep 7, 2018
@dougbu dougbu added this to the 2.2.0-preview3 milestone Sep 7, 2018
@dougbu dougbu self-assigned this Sep 7, 2018
dougbu added a commit that referenced this issue Sep 11, 2018
@dougbu
Remove batching requirements placed on code and document generator pr…
4f1c82c 
…oviders

- #8419
- perform final item additions in common code too
- take advantage of new simplicity in `DefaultDocumentGenerator` targets
dougbu added a commit that referenced this issue Sep 19, 2018
@dougbu
Remove batching requirements placed on code and document generator pr…
78141d5 
…oviders

- #8419
- perform batching and `@(ServiceFileReference)` and `@(Compile)` additions in common code
  - take advantage of new simplicity in `DefaultDocumentGenerator` target
- add metadata serialization / deserialization in support of passing items into `<MSBuild />`
  - also ensure metadata values are escaped before calling `ITaskItem.SetMetadata(...)`
- correct typos in Microsoft.Extensions.ApiDescription.Client.* e.g. in comments and metadata names
- move last remaining `GenerationTasks` file

nits:
- combine `_ServiceProjectReferenceGenerator_Restore` and `_ServiceProjectReferenceGenerator_Build` targets
- remove unused `buildMultiTargeting` targets
- remove qualification of metadata listed in an `<ItemDefinitionGroup />`; will always exist
- add / remove a few `Condition`s that were missing / redundant
- move properties users won't normally set to Microsoft.Extensions.ApiDescription.Client.targets
- shorten lines in MSBuild files
@dougbu dougbu mentioned this issue Sep 19, 2018
Merged
dougbu added a commit that referenced this issue Sep 20, 2018
@dougbu
Remove batching requirements placed on code and document generator pr…
67c833c 
…oviders

- #8419
- perform batching and `@(ServiceFileReference)` and `@(Compile)` additions in common code
  - take advantage of new simplicity in `DefaultDocumentGenerator` target
- add metadata serialization / deserialization in support of passing items into `<MSBuild />`
  - also ensure metadata values are escaped before calling `ITaskItem.SetMetadata(...)`
- correct typos in Microsoft.Extensions.ApiDescription.Client.* e.g. in comments and metadata names
- move last remaining `GenerationTasks` file

nits:
- combine `_ServiceProjectReferenceGenerator_Restore` and `_ServiceProjectReferenceGenerator_Build` targets
  - only build web sites projects once
- remove unused `buildMultiTargeting` targets
- remove qualification of metadata listed in an `<ItemDefinitionGroup />`; will always exist
- add / remove a few `Condition`s that were missing / redundant
- move properties users won't normally set to Microsoft.Extensions.ApiDescription.Client.targets
- shorten lines in MSBuild files
dougbu added a commit that referenced this issue Sep 20, 2018
@dougbu
Remove batching requirements placed on code and document generator pr…
1646345 
…oviders

- #8419
- perform batching and `@(ServiceFileReference)` and `@(Compile)` additions in common code
  - take advantage of new simplicity in `DefaultDocumentGenerator` target
- add metadata serialization / deserialization in support of passing items into `<MSBuild />`
  - also ensure metadata values are escaped before calling `ITaskItem.SetMetadata(...)`
- correct typos in Microsoft.Extensions.ApiDescription.Client.* e.g. in comments and metadata names
- move last remaining `GenerationTasks` file

nits:
- combine `_ServiceProjectReferenceGenerator_Restore` and `_ServiceProjectReferenceGenerator_Build` targets
  - only build web sites projects once
- remove unused `buildMultiTargeting` targets
- remove qualification of metadata listed in an `<ItemDefinitionGroup />`; will always exist
- add / remove a few `Condition`s that were missing / redundant
- move properties users won't normally set to Microsoft.Extensions.ApiDescription.Client.targets
- shorten lines in MSBuild files
@mkArtakMSFT mkArtakMSFT added the PRI: 0 - Critical Blocks a critical product path. Must be handled immediately label Sep 21, 2018
@dougbu
Copy link
Contributor Author

dougbu commented Sep 21, 2018

1646345

@dougbu dougbu closed this as completed Sep 21, 2018
dougbu added a commit that referenced this issue Sep 21, 2018
@dougbu
Correct metadata additions and add errors about metadata
7084b67 
- related to #8419 and (more generally) #7947
- add errors for missing required metadata
- add errors for duplicate `%(DocumentPath)` and `%(OutputPath)` metadata
- remove `[Required]` for task inputs that may be `null` or empty
- correct `%(DocumentPath)`s generated in `GetProjectReferenceMetadata` task
  - use this task
dougbu added a commit that referenced this issue Sep 27, 2018
@dougbu
Correct metadata additions and add errors about metadata
9d109f5 
- related to #8419 and (more generally) #7947
- add errors for missing required metadata
- add errors for duplicate `%(DocumentPath)` and `%(OutputPath)` metadata
- remove `[Required]` for task inputs that may be `null` or empty
- correct `%(DocumentPath)`s generated in `GetProjectReferenceMetadata` task
  - use this task
dougbu added a commit that referenced this issue Oct 4, 2018
@dougbu
Remove batching requirements placed on code and document generator pr…
cac8b26 
…oviders

- #8419
- perform batching and `@(ServiceFileReference)` and `@(Compile)` additions in common code
  - take advantage of new simplicity in `DefaultDocumentGenerator` target
- add metadata serialization / deserialization in support of passing items into `<MSBuild />`
  - also ensure metadata values are escaped before calling `ITaskItem.SetMetadata(...)`
- correct typos in Microsoft.Extensions.ApiDescription.Client.* e.g. in comments and metadata names
- move last remaining `GenerationTasks` file

nits:
- combine `_ServiceProjectReferenceGenerator_Restore` and `_ServiceProjectReferenceGenerator_Build` targets
  - only build web sites projects once
- remove unused `buildMultiTargeting` targets
- remove qualification of metadata listed in an `<ItemDefinitionGroup />`; will always exist
- add / remove a few `Condition`s that were missing / redundant
- move properties users won't normally set to Microsoft.Extensions.ApiDescription.Client.targets
- shorten lines in MSBuild files
dougbu added a commit that referenced this issue Oct 4, 2018
@dougbu
Correct metadata additions and add errors about metadata
96aa71c 
- related to #8419 and (more generally) #7947
- add errors for missing required metadata
- add errors for duplicate `%(DocumentPath)` and `%(OutputPath)` metadata
- remove `[Required]` for task inputs that may be `null` or empty
- correct `%(DocumentPath)`s generated in `GetProjectReferenceMetadata` task
  - use this task
dougbu added a commit that referenced this issue Oct 7, 2018
@dougbu
Remove batching requirements placed on code and document generator pr…
4df514a 
…oviders

- #8419
- perform batching and `@(ServiceFileReference)` and `@(Compile)` additions in common code
  - take advantage of new simplicity in `DefaultDocumentGenerator` target
- add metadata serialization / deserialization in support of passing items into `<MSBuild />`
  - also ensure metadata values are escaped before calling `ITaskItem.SetMetadata(...)`
- correct typos in Microsoft.Extensions.ApiDescription.Client.* e.g. in comments and metadata names
- move last remaining `GenerationTasks` file

nits:
- combine `_ServiceProjectReferenceGenerator_Restore` and `_ServiceProjectReferenceGenerator_Build` targets
  - only build web sites projects once
- remove unused `buildMultiTargeting` targets
- remove qualification of metadata listed in an `<ItemDefinitionGroup />`; will always exist
- add / remove a few `Condition`s that were missing / redundant
- move properties users won't normally set to Microsoft.Extensions.ApiDescription.Client.targets
- shorten lines in MSBuild files
dougbu added a commit that referenced this issue Oct 7, 2018
@dougbu
Correct metadata additions and add errors about metadata
38fe376 
- related to #8419 and (more generally) #7947
- add errors for missing required metadata
- add errors for duplicate `%(DocumentPath)` and `%(OutputPath)` metadata
- remove `[Required]` for task inputs that may be `null` or empty
- correct `%(DocumentPath)`s generated in `GetProjectReferenceMetadata` task
  - use this task
dougbu added a commit that referenced this issue Oct 7, 2018
@dougbu
Remove batching requirements placed on code and document generator pr…
0e9ef9d 
…oviders

- #8419
- perform batching and `@(ServiceFileReference)` and `@(Compile)` additions in common code
  - take advantage of new simplicity in `DefaultDocumentGenerator` target
- add metadata serialization / deserialization in support of passing items into `<MSBuild />`
  - also ensure metadata values are escaped before calling `ITaskItem.SetMetadata(...)`
- correct typos in Microsoft.Extensions.ApiDescription.Client.* e.g. in comments and metadata names
- move last remaining `GenerationTasks` file

nits:
- combine `_ServiceProjectReferenceGenerator_Restore` and `_ServiceProjectReferenceGenerator_Build` targets
  - only build web sites projects once
- remove unused `buildMultiTargeting` targets
- remove qualification of metadata listed in an `<ItemDefinitionGroup />`; will always exist
- add / remove a few `Condition`s that were missing / redundant
- move properties users won't normally set to Microsoft.Extensions.ApiDescription.Client.targets
- shorten lines in MSBuild files
dougbu added a commit that referenced this issue Oct 7, 2018
@dougbu
Correct metadata additions and add errors about metadata
1372726 
- related to #8419 and (more generally) #7947
- add errors for missing required metadata
- add errors for duplicate `%(DocumentPath)` and `%(OutputPath)` metadata
- remove `[Required]` for task inputs that may be `null` or empty
- correct `%(DocumentPath)`s generated in `GetProjectReferenceMetadata` task
  - use this task
dougbu added a commit that referenced this issue Oct 9, 2018
@dougbu
Remove batching requirements placed on code and document generator pr…
f0bd23c 
…oviders

- #8419
- perform batching and `@(ServiceFileReference)` and `@(Compile)` additions in common code
  - take advantage of new simplicity in `DefaultDocumentGenerator` target
- add metadata serialization / deserialization in support of passing items into `<MSBuild />`
  - also ensure metadata values are escaped before calling `ITaskItem.SetMetadata(...)`
- correct typos in Microsoft.Extensions.ApiDescription.Client.* e.g. in comments and metadata names
- move last remaining `GenerationTasks` file

nits:
- combine `_ServiceProjectReferenceGenerator_Restore` and `_ServiceProjectReferenceGenerator_Build` targets
  - only build web sites projects once
- remove unused `buildMultiTargeting` targets
- remove qualification of metadata listed in an `<ItemDefinitionGroup />`; will always exist
- add / remove a few `Condition`s that were missing / redundant
- move properties users won't normally set to Microsoft.Extensions.ApiDescription.Client.targets
- shorten lines in MSBuild files
dougbu added a commit that referenced this issue Oct 9, 2018
@dougbu
Correct metadata additions and add errors about metadata
cc2a42a 
- related to #8419 and (more generally) #7947
- add errors for missing required metadata
- add errors for duplicate `%(DocumentPath)` and `%(OutputPath)` metadata
- remove `[Required]` for task inputs that may be `null` or empty
- correct `%(DocumentPath)`s generated in `GetProjectReferenceMetadata` task
  - use this task
dougbu added a commit that referenced this issue Oct 10, 2018
@dougbu
Remove batching requirements placed on code and document generator pr…
87e3043 
…oviders

- #8419
- perform batching and `@(ServiceFileReference)` and `@(Compile)` additions in common code
  - take advantage of new simplicity in `DefaultDocumentGenerator` target
- add metadata serialization / deserialization in support of passing items into `<MSBuild />`
  - also ensure metadata values are escaped before calling `ITaskItem.SetMetadata(...)`
- correct typos in Microsoft.Extensions.ApiDescription.Client.* e.g. in comments and metadata names
- move last remaining `GenerationTasks` file

nits:
- combine `_ServiceProjectReferenceGenerator_Restore` and `_ServiceProjectReferenceGenerator_Build` targets
  - only build web sites projects once
- remove unused `buildMultiTargeting` targets
- remove qualification of metadata listed in an `<ItemDefinitionGroup />`; will always exist
- add / remove a few `Condition`s that were missing / redundant
- move properties users won't normally set to Microsoft.Extensions.ApiDescription.Client.targets
- shorten lines in MSBuild files
dougbu added a commit that referenced this issue Oct 10, 2018
@dougbu
Correct metadata additions and add errors about metadata
fb9393f 
- related to #8419 and (more generally) #7947
- add errors for missing required metadata
- add errors for duplicate `%(DocumentPath)` and `%(OutputPath)` metadata
- remove `[Required]` for task inputs that may be `null` or empty
- correct `%(DocumentPath)`s generated in `GetProjectReferenceMetadata` task
  - use this task
@dougbu dougbu mentioned this issue Apr 6, 2019
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done cost: S Will take up to 2 days to complete enhancement feature-code-generation PRI: 0 - Critical Blocks a critical product path. Must be handled immediately
Projects
None yet
Milestone
2.2.0-preview3
Development

No branches or pull requests
2 participants
@dougbu @mkArtakMSFT